Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1467123002: X87: [stubs] Change CallICStub to utilize the ConvertReceiverMode. (Closed)

Created:
5 years, 1 month ago by zhengxing.li
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [stubs] Change CallICStub to utilize the ConvertReceiverMode. port d80fd48e5d3d401c10ce95cf8430e5caa9984e32 (r32163) original commit message: The CallICStub has call-site specific knowledge about the receiver, which we did not utilize; plus the CallICStub does in some case know whether it is about to [[Call]] a function or potentially some other callable. In the common case we actually know that the target is a function and so we can use the CallFunction builtin directly instead of redispatching in the Call builtin. BUG= Committed: https://crrev.com/a0ce839241e9444acd10cadd73fed1ac2b4f8a05 Cr-Commit-Position: refs/heads/master@{#32167}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M src/x87/code-stubs-x87.cc View 4 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 1 month ago (2015-11-23 07:45:29 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-11-23 08:20:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467123002/1
5 years, 1 month ago (2015-11-23 08:20:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 08:57:29 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 08:58:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0ce839241e9444acd10cadd73fed1ac2b4f8a05
Cr-Commit-Position: refs/heads/master@{#32167}

Powered by Google App Engine
This is Rietveld 408576698