third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-events-and-exceptions.html - Issue 1467103003: Basic use implementation for MediaStream from Canvas: captureStream()

Side by Side Diff: third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-events-and-exceptions.html

Issue 1467103003: Basic use implementation for MediaStream from Canvas: captureStream() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: haraken@ comments. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html ('k') | third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-events-and-exceptions-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../resources/js-test.js"></script>

	5 </head>

	6 <body>

	7 <p id="description"></p>

	8 <div id="console"></div>

	9 <canvas id="canvas_source"></canvas>

	10 <script>

	11 description("Exercises the potential events on CanvasCaptureMediaStream.");
	Justin Novosad 2015/12/04 14:45:29 Thanks for cleaning up this test. It is much easie Thanks for cleaning up this test. It is much easier to follow now.
	12

	13 var canvas = document.getElementById('canvas_source');

	14 var stream;

	15 var track;

	16

	17 function onVideoPlay() {

	18 testPassed('Video play callback succeeded.');

	19 drawToCanvas(canvas);

	20 };

	21

	22 function onVideoCanPlayThrough() {

	23 testPassed('Video canplaythrough callback succeeded.');

	24 finishJSTest();

	25 };

	26

	27 function drawToCanvas(canvas) {

	28 testPassed('Drawing to canvas.');

	29 var ctx = canvas.getContext("2d");

	30 ctx.strokeStyle="#FF0204";

	31 ctx.beginPath();

	32 ctx.moveTo(0,0);

	33 ctx.lineTo(100, 100);

	34 ctx.stroke();

	35 }

	36

	37 function gotStream() {

	38 shouldBe('stream.getVideoTracks().length', '1');

	39 track = stream.getVideoTracks()[0];

	40 shouldBeEqualToString('track.readyState', 'live');

	41

	42 var video = document.createElement('video');

	43 try {

	44 video.src = window.URL.createObjectURL(stream);

	45 testPassed('Plugged stream to video tag.');

	46 } catch(e) {

	47 testFailed('Exception plugging stream to <video>: ' + e);

	48 finishJSTest();

	49 }

	50 video.addEventListener("play", onVideoPlay);

	51 video.addEventListener("canplaythrough", onVideoCanPlayThrough);

	52 video.play();

	53 };

	54

	55 try {

	56 stream = canvas.captureStream();

	57 testPassed('Got a stream from canvas.');

	58 } catch (e) {

	59 testFailed('Exception calling captureStream(): ' + e);

	60 finishJSTest();
	Justin Novosad 2015/12/04 14:45:29 Here you are potentially calling finishJSTest befo Here you are potentially calling finishJSTest before setting jsTestIsAsync. Justin Novosad 2015/12/04 14:49:24 FWIW, this ordering does not actually matter other Show quoted text On 2015/12/04 14:45:29, Justin Novosad wrote: > Here you are potentially calling finishJSTest before setting jsTestIsAsync. FWIW, this ordering does not actually matter other than for readability. emircan 2015/12/04 18:49:37 Moving it to the beginning of the file. Show quoted text On 2015/12/04 14:49:24, Justin Novosad wrote: > On 2015/12/04 14:45:29, Justin Novosad wrote: > > Here you are potentially calling finishJSTest before setting jsTestIsAsync. > > FWIW, this ordering does not actually matter other than for readability. Moving it to the beginning of the file.
	61 }

	62 gotStream();
	Justin Novosad 2015/12/04 14:45:29 Should not call this if there was an exception. Al Should not call this if there was an exception. Also, functions should be named based on what they do rather than why/when they're called. emircan 2015/12/04 18:49:37 Renaming it to playMediaStream() and moving inside Show quoted text On 2015/12/04 14:45:29, Justin Novosad wrote: > Should not call this if there was an exception. Also, functions should be named > based on what they do rather than why/when they're called. Renaming it to playMediaStream() and moving inside try{} block.
	63

	64 window.jsTestIsAsync = true;

	65 window.successfullyParsed = true;
	Justin Novosad 2015/12/04 14:45:29 This is not necessary. This is not necessary. emircan 2015/12/04 18:49:37 Done. Show quoted text On 2015/12/04 14:45:29, Justin Novosad wrote: > This is not necessary. Done.
	66 </script>

	67 </body>

	68 </html>

OLD	NEW