third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-events-and-exceptions.html - Issue 1467103003: Basic use implementation for MediaStream from Canvas: captureStream()

Side by Side Diff: third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-events-and-exceptions.html

Issue 1467103003: Basic use implementation for MediaStream from Canvas: captureStream() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated LayoutTests. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html ('K') | « third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html ('k') | third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-output.html » ('j') | third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-output.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	Justin Novosad 2015/12/03 15:44:37 missing -expected.txt missing -expected.txt
	2 <script src=../../resources/testharness.js></script>

	3 <script src=../../resources/testharnessreport.js></script>

	4 <script>

	5

	6 var test = async_test('exercises the potential exceptions on ' +

	7 'CanvasCaptureMediaStream and possible events on MediaStream element.');

	8

	9 onStreamActive = test.step_func(function() {
	Justin Novosad 2015/12/03 15:44:37 The assertion implementation in testharness.js lea The assertion implementation in testharness.js leaves no traces in the test results unless it fails. Therefore, this test fails to verify that this event callback gets called at all. Same thing for all the other event callbacks in this test. There is also no validation of the order of execution of the callbacks with respect to each other, and with respect to the actions that trigger them.
	10 assert_equals(stream.active, true);

	11 assert_equals(stream.getVideoTracks().length, 1);

	12 assert_equals(stream.getVideoTracks()[0].readyState, 'live');

	13 assert_equals(stream.getAudioTracks().length, 0);

	14 });

	15

	16 onStreamEnded = test.step_func(function() {

	17 assert_equals(stream.ended, true);

	18 });

	19

	20 onStreamRemoveTrack = test.step_func(function() {

	21 assert_equals(stream.getVideoTracks().length, 0);

	22 assert_equals(stream.getAudioTracks().length, 0);

	23 });

	24

	25 removeTrack = test.step_func(function(stream) {

	26 stream.removeTrack(stream.getVideoTracks()[0]);

	27 });

	28

	29 onTrackStarted = test.step_func(function() {

	30 assert_equals(track.readyState, 'live');

	31 assert_equals(track.enabled, true);

	32 assert_equals(track.muted, false);

	33 });

	34

	35 onTrackEnded = test.step_func(function() {

	36 assert_equals(track.readyState, 'ended');

	37 });

	38

	39 gotStream = test.step_func(function(stream) {

	40 stream.onactive = onStreamActive;

	41 stream.onended = onStreamEnded;

	42

	43 track = stream.getVideoTracks()[0];

	44 track.onstarted = onTrackStarted;

	45 track.onended = onTrackEnded;

	46

	47 var video = document.createElement('video');

	48 try {

	49 video.src = window.URL.createObjectURL(stream);;

	50 } catch(e) {

	51 assert_unreached('Exception plugging stream to <video>: ' + e);

	52 }

	53 video.play();

	54

	55 removeTrack(stream);

	56 test.done();
	Justin Novosad 2015/12/03 15:44:37 Maybe I am misunderstanding how this test works, b Maybe I am misunderstanding how this test works, but calling test.done() here looks like the test will end before any of the event callbacks are called. esprehn 2015/12/03 18:47:34 Yeah are you sure this is right? Show quoted text On 2015/12/03 at 15:44:37, Justin Novosad wrote: > Maybe I am misunderstanding how this test works, but calling test.done() here looks like the test will end before any of the event callbacks are called. Yeah are you sure this is right?
	57 });

	58

	59 var canvas = document.createElement('canvas');

	60 var stream;

	61 var track;

	62 try {

	63 stream = canvas.captureStream();

	64 } catch (e) {

	65 assert_unreached('Exception calling captureStream(): ' + e);

	66 }

	67 gotStream(stream);

	68

	69 </script>

OLD	NEW