third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html - Issue 1467103003: Basic use implementation for MediaStream from Canvas: captureStream()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html

Issue 1467103003: Basic use implementation for MediaStream from Canvas: captureStream() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated LayoutTests. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/renderer/media/canvas_capture_handler.cc ('K') | « content/renderer/renderer_blink_platform_impl.cc ('k') | third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-events-and-exceptions.html » ('j') | third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-events-and-exceptions.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	Justin Novosad 2015/12/03 15:44:37 Missing -expected.txt for this test Missing -expected.txt for this test esprehn 2015/12/03 18:47:34 Do web platform tests need a -expected.txt if they Show quoted text On 2015/12/03 at 15:44:37, Justin Novosad wrote: > Missing -expected.txt for this test Do web platform tests need a -expected.txt if they just print PASS? I didn't think they did. emircan 2015/12/04 03:23:25 Right. "presubmit" checks for that. Show quoted text On 2015/12/03 18:47:34, esprehn wrote: > On 2015/12/03 at 15:44:37, Justin Novosad wrote: > > Missing -expected.txt for this test > > Do web platform tests need a -expected.txt if they just print PASS? I didn't > think they did. Right. "presubmit" checks for that. emircan 2015/12/04 03:23:25 When I add it, I get the below presubmit warning. Show quoted text On 2015/12/03 15:44:37, Justin Novosad wrote: > Missing -expected.txt for this test When I add it, I get the below presubmit warning. I guess, we do not need to add it when it is expected to pass cleanly. The following files are passing testharness results without console error messages, they should be removed: /work/chromium/src/third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-creation-expected.txt ERROR: found passing testharness results without console error messages.
	2 <script src=../../resources/testharness.js></script>

	3 <script src=../../resources/testharnessreport.js></script>

	4 <script>

	5 // This test verifies that MediaStream can be created with captureStream() call.

	6 test(function() {

	7 var canvas = document.createElement('canvas');

	8 var stream = canvas.captureStream();

	9 assert_not_equals(stream, null);

	10 assert_equals(stream.active, true);

	11 assert_equals(stream.getVideoTracks().length, 1);

	12 assert_equals(stream.getAudioTracks().length, 0);

	13 var track = stream.getVideoTracks()[0];

	14 assert_equals(track.readyState, 'live');

	15 assert_equals(track.enabled, true);

	16 assert_equals(track.muted, false);

	17 }, 'check <canvas> captureStream()');

	18

	19 </script>

OLD	NEW