FileAPI: Copy base::FileUtilProxy::Entry to fileapi::DirectoryEntry

webkit/fileapi/file_system_operation.h

Index: webkit/fileapi/file_system_operation.h
diff --git a/webkit/fileapi/file_system_operation.h b/webkit/fileapi/file_system_operation.h
index 35e0a502da78901746e767c991db668289694818..5adf4d2ce9ad4771bf6afa8dfd5ab7eaeaf2b16a 100644
--- a/webkit/fileapi/file_system_operation.h
+++ b/webkit/fileapi/file_system_operation.h
@@ -7,7 +7,8 @@
 
 #include <vector>
 
-#include "base/files/file_util_proxy.h"
+#include "base/callback.h"
+#include "base/files/file_path.h"
 #include "base/platform_file.h"
 #include "base/process.h"
 
@@ -53,6 +54,14 @@ class LocalFileSystemOperation;
 //
 class FileSystemOperation {
  public:
+  // Holds metadata for file or directory entry.

[kinuko, 2013/05/17 02:04:03]

Oops, hiroki, I found this struct is used throughout from browser to renderer
process, and making dependency from renderer to
webkit/fileapi/file_system_operation.h is not great… can you move this to a
separate tiny file (like directory_entry.h) and rename the structure to like:
fileapi::DirectoryEntry ?  (Hopefully other owner's lgtm could be retained for
this minor naming change)

[nhiroki, 2013/05/17 06:12:53]

Done.

+  struct Entry {
+    base::FilePath::StringType name;
+    bool is_directory;
+    int64 size;
+    base::Time last_modified_time;
+  };
+
   virtual ~FileSystemOperation() {}
 
   // Used for CreateFile(), etc. |result| is the return code of the operation.
@@ -76,7 +85,7 @@ class FileSystemOperation {
            base::ProcessHandle peer_handle)> OpenFileCallback;
 
   // Used for ReadDirectoryCallback.
-  typedef std::vector<base::FileUtilProxy::Entry> FileEntryList;
+  typedef std::vector<FileSystemOperation::Entry> FileEntryList;
 
   // Used for ReadDirectory(). |result| is the return code of the operation,
   // |file_list| is the list of files read, and |has_more| is true if some files