Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 14671017: Remove assert that is no longer valid. (Closed)

Created:
7 years, 7 months ago by bsalomon
Modified:
7 years, 7 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove assert that is no longer valid. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=9129

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/gpu/gl/GrGpuGL.cpp View 1 chunk +0 lines, -4 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
7 years, 7 months ago (2013-05-14 18:45:18 UTC) #1
robertphillips
https://codereview.chromium.org/14671017/diff/1/src/gpu/gl/GrGpuGL.cpp File src/gpu/gl/GrGpuGL.cpp (left): https://codereview.chromium.org/14671017/diff/1/src/gpu/gl/GrGpuGL.cpp#oldcode480 src/gpu/gl/GrGpuGL.cpp:480: glDesc.fIsWrapped = true; I don't think we should delete ...
7 years, 7 months ago (2013-05-14 19:22:15 UTC) #2
bsalomon
https://codereview.chromium.org/14671017/diff/1/src/gpu/gl/GrGpuGL.cpp File src/gpu/gl/GrGpuGL.cpp (left): https://codereview.chromium.org/14671017/diff/1/src/gpu/gl/GrGpuGL.cpp#oldcode480 src/gpu/gl/GrGpuGL.cpp:480: glDesc.fIsWrapped = true; On 2013/05/14 19:22:15, robertphillips wrote: > ...
7 years, 7 months ago (2013-05-14 19:34:56 UTC) #3
robertphillips
lgtm
7 years, 7 months ago (2013-05-14 19:36:18 UTC) #4
bsalomon
7 years, 7 months ago (2013-05-14 19:56:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r9129 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698