Issue 14671011: Merge 199501 "[Android] Always set "mobile user agent" switch to..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14671011: Merge 199501 "[Android] Always set "mobile user agent" switch to..." (Closed)

Created:
7 years, 7 months ago by Yaron

Modified:
7 years, 7 months ago

Reviewers:
Yaron

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/branches/1500/src/

Visibility:
Public.

More Reviews

Description

Merge 199501 "[Android] Always set "mobile user agent" switch to..." > [Android] Always set "mobile user agent" switch to the right vlaue when launching the browser process. > > This fixes the user agent for the browser process when the browser process has been started by an activity other than Main, like sync, bookmark provider, etc. If > chrome is started as a background process, the switch is never added. Since the > user agent is computed early on during start-up and not recomputed (from users > of content::GetUserAgent) this can lead to incorrect UA being reported and > broken results. > > We probably shouldn't do it this way long-term but this is a minimal fix for m27. > > NOTRY=true > BUG=237471 > > Review URL: https://chromiumcodereview.appspot.com/14682021 TBR=yfriedman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199829

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	content/public/android/java/src/org/chromium/content/browser/AndroidBrowserProcess.java	View		2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r199829.

Expand Messages | Collapse Messages