Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1467083002: Mustash: Move RenderWidgetHostViewMus from frame_host => renderer_host (Closed)

Created:
5 years, 1 month ago by Fady Samuel
Modified:
5 years, 1 month ago
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mustash: Move RenderWidgetHostViewMus from frame_host => renderer_host We are not yet addressing the subframe case so renderer_host is a better place for this file. BUG=551250 Committed: https://crrev.com/402274e42cb72fde4f48a4bb01664d0ad4533c69 Cr-Commit-Position: refs/heads/master@{#361057}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -419 lines) Patch
M content/browser/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D content/browser/frame_host/render_widget_host_view_mus.h View 1 chunk +0 lines, -133 lines 0 comments Download
D content/browser/frame_host/render_widget_host_view_mus.cc View 1 chunk +0 lines, -279 lines 0 comments Download
A + content/browser/renderer_host/render_widget_host_view_mus.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/renderer_host/render_widget_host_view_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_mus.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Fady Samuel
+ben@ who suggested the change +sadrul@ for OWNER approval.
5 years, 1 month ago (2015-11-22 22:12:17 UTC) #2
Ben Goodger (Google)
lgtm
5 years, 1 month ago (2015-11-22 22:21:49 UTC) #3
sadrul
Note that code in renderer_host can't use code in frame_host, which has made some changes ...
5 years, 1 month ago (2015-11-22 22:42:14 UTC) #4
Fady Samuel
On 2015/11/22 22:42:14, sadrul wrote: > Note that code in renderer_host can't use code in ...
5 years, 1 month ago (2015-11-22 22:57:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467083002/1
5 years, 1 month ago (2015-11-22 22:57:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-22 23:38:13 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-22 23:38:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/402274e42cb72fde4f48a4bb01664d0ad4533c69
Cr-Commit-Position: refs/heads/master@{#361057}

Powered by Google App Engine
This is Rietveld 408576698