Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

Issue 1467063002: Introduce the ChromeControllerClient class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
index 98668c9ba57c6a83d7defa6a323b6967b6a58004..65e142fa82189ea4179ac563103cb9025ededcff 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
@@ -33,6 +33,7 @@
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/test_switches.h"
#include "chrome/test/base/ui_test_utils.h"
+#include "components/security_interstitials/core/controller_client.h"
#include "components/security_interstitials/core/metrics_helper.h"
#include "content/public/browser/interstitial_page.h"
#include "content/public/browser/navigation_controller.h"
@@ -51,6 +52,7 @@ using content::BrowserThread;
using content::InterstitialPage;
using content::NavigationController;
using content::WebContents;
+using security_interstitials::ControllerClient;
namespace safe_browsing {
@@ -428,8 +430,7 @@ class SafeBrowsingBlockingPageBrowserTest
return url;
}
- void SendCommand(
- SecurityInterstitialPage::SecurityInterstitialCommands command) {
+ void SendCommand(ControllerClient::SecurityInterstitialCommands command) {
WebContents* contents =
browser()->tab_strip_model()->GetActiveWebContents();
// We use InterstitialPage::GetInterstitialPage(tab) instead of
@@ -529,7 +530,7 @@ class SafeBrowsingBlockingPageBrowserTest
// below, and crbug.com/76460), we use SendCommand to trigger the callback
// directly rather than using ClickAndWaitForDetach since there might not
// be a notification to wait for.
- SendCommand(SecurityInterstitialPage::CMD_PROCEED);
+ SendCommand(ControllerClient::CMD_PROCEED);
}
content::RenderViewHost* GetRenderViewHost() {
@@ -783,7 +784,7 @@ IN_PROC_BROWSER_TEST_P(SafeBrowsingBlockingPageBrowserTest, ProceedDisabled) {
EXPECT_TRUE(Click("details-button"));
EXPECT_EQ(HIDDEN, GetVisibility("proceed-link"));
EXPECT_EQ(HIDDEN, GetVisibility("final-paragraph"));
- SendCommand(SecurityInterstitialPage::CMD_PROCEED);
+ SendCommand(ControllerClient::CMD_PROCEED);
// The "proceed" command should go back instead, if proceeding is disabled.
AssertNoInterstitial(true);

Powered by Google App Engine
This is Rietveld 408576698