A64: Add more descriptive messages to aborts

src/a64/lithium-codegen-a64.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1155 matching lines @@
     LConstantOperand* const_op = LConstantOperand::cast(op);
     HConstant* constant = chunk()->LookupConstant(const_op);
     Representation r = chunk_->LookupLiteralRepresentation(const_op);
     if (r.IsInteger32()) {
       ASSERT(constant->HasInteger32Value());
       return Operand(signedness == SIGNED_INT32
                      ? constant->Integer32Value()
                      : static_cast<uint32_t>(constant->Integer32Value()));
     } else {
       // Other constants not implemented.
-      // TODO(all): Add this error code to objects.h.
-      // Abort(kToOperand32UnsupportedImmediate);
-      Abort(kUnknown);
+      Abort(kToOperand32UnsupportedImmediate);
     }
   }
   // Other cases are not implemented.
   UNREACHABLE();
   return Operand(0);
 }
 
 
 MemOperand LCodeGen::ToMemOperand(LOperand* op) const {
   ASSERT(op != NULL);
@@ skipping 475 matching lines @@
     case Token::BIT_XOR: __ Eor(result, left, right); break;
     default:
       UNREACHABLE();
       break;
   }
 }
 
 
 void LCodeGen::ApplyCheckIf(Condition cc, LBoundsCheck* check) {
   if (FLAG_debug_code && check->hydrogen()->skip_check()) {
-    // TODO(all): Add this error code to objects.h.
-    // __ Assert(InvertCondition(cc), kEliminatedBoundsCheckFailed);
-    __ Assert(InvertCondition(cc), kUnknown);
+    __ Assert(InvertCondition(cc), kEliminatedBoundsCheckFailed);
   } else {
     DeoptimizeIf(cc, check->environment());
   }
 }
 
 
 void LCodeGen::DoBoundsCheck(LBoundsCheck *instr) {
   if (instr->hydrogen()->skip_check()) return;
 
   Register length = ToRegister(instr->length());
@@ skipping 179 matching lines @@
   // If necessary, load the function object.
   if (function_reg.IsNone()) {
     function_reg = x1;
     __ LoadHeapObject(function_reg, function);
   }
 
   if (FLAG_debug_code) {
     Label is_not_smi;
     // Try to confirm that function_reg (x1) is a tagged pointer.
     __ JumpIfNotSmi(function_reg, &is_not_smi);
-    // TODO(all): Add this error code to objects.h.
-    // __ Abort(kExpectedFunctionObject);
-    __ Abort(kUnknown);
+    __ Abort(kExpectedFunctionObject);
     __ Bind(&is_not_smi);
   }
 
   if (can_invoke_directly) {
     // Change context.
     __ Ldr(cp, FieldMemOperand(function_reg, JSFunction::kContextOffset));
 
     // Set the arguments count if adaption is not needed. Assumes that x0 is
     // available to write to at this point.
     if (dont_adapt_arguments) {
@@ skipping 2447 matching lines @@
   __ Bind(&slow);
 
   // Check that the dst register contains new space allocation top, which is a
   // valid address for the GC.
   if (FLAG_debug_code) {
     ExternalReference new_space_allocation_top =
         ExternalReference::new_space_allocation_top_address(isolate());
     __ Mov(scratch1, Operand(new_space_allocation_top));
     __ Ldr(scratch1, MemOperand(scratch1));
     __ Cmp(dst, scratch1);
-    // TODO(all): Add this error code to objects.h.
-    // __ Check(eq, kRegisterDstDoesNotContainAllocationTop);
-    __ Check(eq, kUnknown);
+    __ Check(eq, kUnexpectedAllocationTop);
   }
 
   {
     // Preserve the value of all registers.
     PushSafepointRegistersScope scope(this, Safepoint::kWithRegisters);
 
     CallRuntimeFromDeferred(Runtime::kAllocateHeapNumber, 0, instr);
     __ StoreToSafepointRegisterSlot(x0, dst);
   }
 
@@ skipping 114 matching lines @@
 
 
 void LCodeGen::DoParameter(LParameter* instr) {
   // Nothing to do.
 }
 
 
 void LCodeGen::DoPushArgument(LPushArgument* instr) {
   LOperand* argument = instr->value();
   if (argument->IsDoubleRegister() || argument->IsDoubleStackSlot()) {
-    // TODO(all): Add this error code to objects.h.
-    // Abort(kDoPushArgumentNotImplementedForDoubleTypes);
-    Abort(kUnknown);
+    Abort(kDoPushArgumentNotImplementedForDoubleType);
   } else {
     __ Push(ToRegister(argument));
   }
 }
 
 
 void LCodeGen::DoReturn(LReturn* instr) {
   if (FLAG_trace && info()->IsOptimizing()) {
     // Push the return value on the stack as the parameter.
     // Runtime::TraceExit returns its parameter in x0.
@@ skipping 1107 matching lines @@
   __ Bind(&out_of_object);
   __ Ldr(result, FieldMemOperand(object, JSObject::kPropertiesOffset));
   // Index is equal to negated out of object property index plus 1.
   __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2));
   __ Ldr(result, FieldMemOperand(result,
                                  FixedArray::kHeaderSize - kPointerSize));
   __ Bind(&done);
 }
 
 } }  // namespace v8::internal