Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 146703007: Update newlib version use in all toolchain builds (Closed)

Created:
6 years, 10 months ago by Sam Clegg
Modified:
6 years, 10 months ago
Reviewers:
Roland McGrath
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Update newlib version in tools/REVISIONS This brings in the following newlib change: 41e7008: Revert "Fix race condition in concurrent printf and fopen." For the pnacl toolchain which was lagging it also brings in the following four changes: cc9ce45: Add -D_I386MACH_ALLOW_HW_INTERRUPTS in configure.host for nacl 489f1d8: Include more of sys/types.h and sys/signal.h under NaCl 02b55a2: Define _POSIX_THREADS under NaCl. 9f95ad0: Fix computed jump calculations in ARM memcpy TEST= toolchain bots + toolchain_build/toolchain_build.py BUG= https://code.google.com/p/chromium/issues/detail?id=338220 R=mcgrathr@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=12686

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M pnacl/COMPONENT_REVISIONS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M toolchain_build/toolchain_build.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/REVISIONS View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Sam Clegg
6 years, 10 months ago (2014-01-30 00:16:51 UTC) #1
Sam Clegg
PTAL. The windows toolchain bot failure don't look related to this change, right?
6 years, 10 months ago (2014-01-30 18:51:21 UTC) #2
Roland McGrath
lgtm
6 years, 10 months ago (2014-01-30 19:17:12 UTC) #3
Sam Clegg
The CQ bit was checked by sbc@chromium.org
6 years, 10 months ago (2014-02-01 22:52:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/sbc@chromium.org/146703007/40001
6 years, 10 months ago (2014-02-01 22:52:59 UTC) #5
Sam Clegg
Committed patchset #3 manually as r12686 (presubmit successful).
6 years, 10 months ago (2014-02-01 22:53:30 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 22:53:31 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 22:53:32 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-01 22:53:34 UTC) #9
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698