Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 146703006: [GCM] Create and use event router in GCMProfileService (Closed)

Created:
6 years, 10 months ago by jianli
Modified:
6 years, 10 months ago
Reviewers:
fgorski
CC:
chromium-reviews
Visibility:
Public.

Description

[GCM] Create and use event router in GCMProfileService BUG=284553 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247872

Patch Set 1 #

Patch Set 2 : Fix trybots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M chrome/browser/services/gcm/gcm_profile_service.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service.cc View 1 3 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jianli
6 years, 10 months ago (2014-01-29 22:28:15 UTC) #1
fgorski
lgtm
6 years, 10 months ago (2014-01-29 22:41:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/146703006/20001
6 years, 10 months ago (2014-01-30 00:34:33 UTC) #3
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 07:29:06 UTC) #4
Message was sent while issue was closed.
Change committed as 247872

Powered by Google App Engine
This is Rietveld 408576698