Issue 146703005: Support creation of RGB565 JavaBitmap from helper.

Issue 146703005: Support creation of RGB565 JavaBitmap from helper. (Closed)

Created:
6 years, 10 months ago by sivag

Modified:
6 years, 10 months ago

Reviewers:
Yaron, no sievers

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Support creation of RGB565 JavaBitmap from helper. Now we have the copyFromCompositingSurface with format support. We should be able to create the JavaBitmap with the selected Config. BUG=323150 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248404

Patch Set 1 #

Patch Set 2 : Set proper indentation in helper. #

Total comments: 2

Patch Set 3 : Change the visibility of helper function to private. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -6 lines)			Patch
	M	ui/android/java/src/org/chromium/ui/gfx/BitmapHelper.java	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download
	M	ui/gfx/android/java_bitmap.cc	View		1 chunk	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

no sievers

lgtm https://codereview.chromium.org/146703005/diff/20001/ui/android/java/src/org/chromium/ui/gfx/BitmapHelper.java File ui/android/java/src/org/chromium/ui/gfx/BitmapHelper.java (right): https://codereview.chromium.org/146703005/diff/20001/ui/android/java/src/org/chromium/ui/gfx/BitmapHelper.java#newcode20 ui/android/java/src/org/chromium/ui/gfx/BitmapHelper.java:20: public static Bitmap createBitmap(int width, Can you make ...

6 years, 10 months ago (2014-01-29 23:31:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siva.gunturi@samsung.com/146703005/40001

6 years, 10 months ago (2014-02-02 06:17:22 UTC) #5

commit-bot: I haz the power

CQ bit was unchecked on CL. Ignoring.

6 years, 10 months ago (2014-02-02 14:14:00 UTC) #7

commit-bot: I haz the power

CQ bit was unchecked on CL. Ignoring.

6 years, 10 months ago (2014-02-02 14:14:08 UTC) #8

sivag

6 years, 10 months ago (2014-02-03 02:28:31 UTC) #9

Message was sent while issue was closed.

https://codereview.chromium.org/146703005/diff/20001/ui/android/java/src/org/...
File ui/android/java/src/org/chromium/ui/gfx/BitmapHelper.java (right):

https://codereview.chromium.org/146703005/diff/20001/ui/android/java/src/org/...
ui/android/java/src/org/chromium/ui/gfx/BitmapHelper.java:20: public static
Bitmap createBitmap(int width,
On 2014/01/29 23:31:54, sievers wrote:
> Can you make this method private? I think it's only supposed to be used from
> native as a factory.

Done.

Expand Messages | Collapse Messages