base/memory/singleton_unittest.cc - Issue 1467003002: Switch to static_assert in base/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/singleton_unittest.cc

Issue 1467003002: Switch to static_assert in base/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: missed one Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/memory/singleton_unittest.cc

diff --git a/base/memory/singleton_unittest.cc b/base/memory/singleton_unittest.cc

index e8788babdfda8bec033b758c242e94705cbfb0ed..b86dcc20d3162a53e2a418f64a0571db20c5bd44 100644

--- a/base/memory/singleton_unittest.cc

+++ b/base/memory/singleton_unittest.cc

@@ -9,7 +9,7 @@

namespace base {

namespace {

-COMPILE_ASSERT(DefaultSingletonTraits<int>::kRegisterAtExit == true, a);

+static_assert(DefaultSingletonTraits<int>::kRegisterAtExit == true, "a");

Mostyn Bramley-Moore 2015/11/23 06:44:14 Maybe change the message to something like "object

Avi (use Gerrit) 2015/11/24 04:49:43 Done.

typedef void (*CallbackFunc)();