base/macros.h - Issue 1467003002: Switch to static_assert in base/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/macros.h

Issue 1467003002: Switch to static_assert in base/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: missed one Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/macros.h

diff --git a/base/macros.h b/base/macros.h

index c5f503fbc3ae9158f82ecd3f487ac0e13bb7ae77..af1cb386afc32c3940c3866a3ec64f02796f5eff 100644

--- a/base/macros.h

+++ b/base/macros.h

@@ -129,7 +129,7 @@ template <typename T, size_t N> char (&ArraySizeHelper(T (&array)[N]))[N];

template <class Dest, class Source>

inline Dest bit_cast(const Source& source) {

- COMPILE_ASSERT(sizeof(Dest) == sizeof(Source), VerifySizesAreEqual);

+ static_assert(sizeof(Dest) == sizeof(Source), "VerifySizesAreEqual");

Dest dest;

memcpy(&dest, &source, sizeof(dest));