base/atomicops_internals_x86_msvc.h - Issue 1467003002: Switch to static_assert in base/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/atomicops_internals_x86_msvc.h

Issue 1467003002: Switch to static_assert in base/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: missed one Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/atomicops_internals_x86_msvc.h

diff --git a/base/atomicops_internals_x86_msvc.h b/base/atomicops_internals_x86_msvc.h

index 71ddca2ba387a11dd0b53a48cdcbbf6a737f03f4..8da873522a5e15d967957c9fdc9b2153426be198 100644

--- a/base/atomicops_internals_x86_msvc.h

+++ b/base/atomicops_internals_x86_msvc.h

@@ -109,7 +109,7 @@ inline Atomic32 Release_Load(volatile const Atomic32* ptr) {

// 64-bit low-level operations on 64-bit platform.

-COMPILE_ASSERT(sizeof(Atomic64) == sizeof(PVOID), atomic_word_is_atomic);

+static_assert(sizeof(Atomic64) == sizeof(PVOID), "atomic_word_is_atomic");

inline Atomic64 NoBarrier_CompareAndSwap(volatile Atomic64* ptr,

Atomic64 old_value,