Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 14670022: Make sure the main header is not included twice in the generated implementation (Closed)

Created:
7 years, 7 months ago by do-not-use
Modified:
7 years, 7 months ago
CC:
blink-reviews, haraken, Nate Chapin, eae+blinkwatch, jsbell+bindings_chromium.org, abarth-chromium, lgombos
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make sure the main header is not included twice in the generated implementation r149976 updated the bindings generator so that the main header is not included twice in the generated implementation under most circumstances. However, the fix was incomplete as the bug is still reproduceable if an IDL interface refers to itself (i.e. one of the attributes or arguments has the interface as type). This patch addresses the issue by using the implIncludes hash map for the main header include, instead of hardcoding it in the header section. The main include is then treated as a special case in WriteData subroutine to make sure it is printed right after the "config.h" include and followed by a blank line. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149994

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M Source/bindings/scripts/CodeGeneratorV8.pm View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestObj.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
do-not-use
7 years, 7 months ago (2013-05-08 22:34:32 UTC) #1
do-not-use
Sorry I missed that.
7 years, 7 months ago (2013-05-08 22:34:56 UTC) #2
abarth-chromium
lgtm
7 years, 7 months ago (2013-05-09 00:30:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/14670022/1
7 years, 7 months ago (2013-05-09 00:30:47 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-09 01:26:03 UTC) #5
Message was sent while issue was closed.
Change committed as 149994

Powered by Google App Engine
This is Rietveld 408576698