Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14670019: Add a deprecation warning for document.clear() (Closed)

Created:
7 years, 7 months ago by arv (Not doing code reviews)
Modified:
7 years, 7 months ago
CC:
blink-reviews, haraken, Nate Chapin, jsbell+bindings_chromium.org, abarth-chromium
Visibility:
Public.

Description

Add a deprecation warning for document.clear() BUG=238784 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149897

Patch Set 1 #

Total comments: 3

Patch Set 2 : Change message slightly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M LayoutTests/fast/dom/document-clear-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/scripts/CodeGeneratorV8.pm View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLDocument.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/UseCounter.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
arv (Not doing code reviews)
https://codereview.chromium.org/14670019/diff/1/Source/bindings/scripts/CodeGeneratorV8.pm File Source/bindings/scripts/CodeGeneratorV8.pm (right): https://codereview.chromium.org/14670019/diff/1/Source/bindings/scripts/CodeGeneratorV8.pm#newcode1268 Source/bindings/scripts/CodeGeneratorV8.pm:1268: AddToImplIncludes("core/page/UseCounter.h"); If the idl file only has DeprecateAs but ...
7 years, 7 months ago (2013-05-07 20:20:47 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/14670019/diff/1/Source/core/page/UseCounter.cpp File Source/core/page/UseCounter.cpp (right): https://codereview.chromium.org/14670019/diff/1/Source/core/page/UseCounter.cpp#newcode149 Source/core/page/UseCounter.cpp:149: return "document.clear() is deprecated."; Is there an alternative ...
7 years, 7 months ago (2013-05-07 20:24:45 UTC) #2
esprehn
LGTM. https://codereview.chromium.org/14670019/diff/1/Source/core/page/UseCounter.cpp File Source/core/page/UseCounter.cpp (right): https://codereview.chromium.org/14670019/diff/1/Source/core/page/UseCounter.cpp#newcode149 Source/core/page/UseCounter.cpp:149: return "document.clear() is deprecated."; On 2013/05/07 20:24:46, abarth ...
7 years, 7 months ago (2013-05-07 20:25:52 UTC) #3
abarth-chromium
Ah, it does nothing. Maybe we should say that in the message. :)
7 years, 7 months ago (2013-05-07 20:26:09 UTC) #4
arv (Not doing code reviews)
On 2013/05/07 20:26:09, abarth wrote: > Ah, it does nothing. Maybe we should say that ...
7 years, 7 months ago (2013-05-07 20:27:56 UTC) #5
abarth-chromium
SGTM
7 years, 7 months ago (2013-05-07 20:41:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/14670019/9001
7 years, 7 months ago (2013-05-07 20:41:35 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-07 22:13:04 UTC) #8
Message was sent while issue was closed. 
Change committed as 149897

Powered by Google App Engine
This is Rietveld 408576698