Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 1466943002: PPC: [runtime] Introduce a proper %NewArray runtime entry. (Closed)

Created:
5 years, 1 month ago by MTBrandyberry
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [runtime] Introduce a proper %NewArray runtime entry. Port ceade6cf239e0773213d53d55c36b19231c820b5 Original commit message: This adds a new %NewArray runtime entry, which constructs a new JSArray and does the subclassing correctly (to the same degree that %NewObject does currently), and also deals properly with the AllocationSite feedback mechanism. This runtime entry will be used by TurboFan and is also used as a fallback in the subclassing case in the stub currently. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:3101, v8:3330 LOG=n Committed: https://crrev.com/8ced019a5936b55f9c2e647ff529a42f55c03d22 Cr-Commit-Position: refs/heads/master@{#32180}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M src/ppc/code-stubs-ppc.cc View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 1 month ago (2015-11-20 23:44:39 UTC) #1
michael_dawson
On 2015/11/20 23:44:39, mtbrandyberry wrote: lgtm
5 years, 1 month ago (2015-11-23 14:23:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466943002/1
5 years, 1 month ago (2015-11-23 14:37:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 14:59:30 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 15:00:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ced019a5936b55f9c2e647ff529a42f55c03d22
Cr-Commit-Position: refs/heads/master@{#32180}

Powered by Google App Engine
This is Rietveld 408576698