Source/web/FrameLoaderClientImpl.cpp - Issue 146693005: Clarify when what notifications are send when a window object is cleared

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FrameLoaderClientImpl.cpp

Issue 146693005: Clarify when what notifications are send when a window object is cleared (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: updates Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/FrameLoaderClientImpl.cpp

diff --git a/Source/web/FrameLoaderClientImpl.cpp b/Source/web/FrameLoaderClientImpl.cpp

index d687139032a69b61d358abbfc8e5b78efb30e786..254645e8f83b23c9250a7bb26f462da8a436243d 100644

--- a/Source/web/FrameLoaderClientImpl.cpp

+++ b/Source/web/FrameLoaderClientImpl.cpp

@@ -113,10 +113,10 @@ FrameLoaderClientImpl::~FrameLoaderClientImpl()

{

}

-void FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld(DOMWrapperWorld& world)

+void FrameLoaderClientImpl::dispatchDidClearWindowObjectInMainWorld()

{

if (m_webFrame->client()) {

- m_webFrame->client()->didClearWindowObject(m_webFrame, world.worldId());

+ m_webFrame->client()->didClearWindowObject(m_webFrame);

Document* document = m_webFrame->frame()->document();

if (document) {

WheelController::from(*document);