Source/bindings/v8/ScriptController.cpp - Issue 146693005: Clarify when what notifications are send when a window object is cleared

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptController.cpp

Issue 146693005: Clarify when what notifications are send when a window object is cleared (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: updates Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScriptController.cpp

diff --git a/Source/bindings/v8/ScriptController.cpp b/Source/bindings/v8/ScriptController.cpp

index f685c9f48d4effa74569b2f56a446ea77a3b6922..231bcd1516c5fbf110fb599c5b0989556ec0b4cf 100644

--- a/Source/bindings/v8/ScriptController.cpp

+++ b/Source/bindings/v8/ScriptController.cpp

@@ -238,8 +238,8 @@ V8WindowShell* ScriptController::windowShell(DOMWrapperWorld& world)

m_isolatedWorlds.set(world.worldId(), isolatedWorldShell.release());

}

- if (!shell->isContextInitialized() && shell->initializeIfNeeded())

- m_frame->loader().dispatchDidClearWindowObjectInWorld(world);

+ if (!shell->isContextInitialized() && shell->initializeIfNeeded() && world.isMainWorld())

+ m_frame->loader().dispatchDidClearWindowObjectInMainWorld();

return shell;

}