Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 14669003: [android_webview] Deps whitelist and scripts for AOSP builder (Closed)

Created:
7 years, 7 months ago by mkosiba (inactive)
Modified:
7 years, 7 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org, kjellander_chromium
Visibility:
Public.

Description

[android_webview] Deps whitelist and scripts for AOSP builder. This check in the whitelist that will be used to calculate the set of DEPS used to checkout Chromium in the AOSP builder configuration. This also adds the script to generate the local manifest which excludes any previous Chromium snapshots. Finally this also adds a simple wrapper used to execute commands within a lunch-ed environment. BUG=175394 TEST=None NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202067

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : make the whitelist a Python script #

Patch Set 4 : moved 'with_lunch' script to depot tools #

Patch Set 5 : make the whitelist script generate JSON #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -0 lines) Patch
A + android_webview/buildbot/OWNERS View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A android_webview/buildbot/deps_whitelist.py View 1 2 3 4 5 1 chunk +192 lines, -0 lines 0 comments Download
A android_webview/buildbot/generate_local_manifest.py View 1 2 3 4 5 1 chunk +100 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mkosiba (inactive)
7 years, 7 months ago (2013-05-03 13:19:51 UTC) #1
mkosiba (inactive)
ping?
7 years, 7 months ago (2013-05-04 19:29:52 UTC) #2
mkosiba (inactive)
ignore this ping. I wanted to ping the other CL. On Sat, May 4, 2013 ...
7 years, 7 months ago (2013-05-04 20:33:37 UTC) #3
mkosiba (inactive)
ok, the whitelist is now a Python script.
7 years, 7 months ago (2013-05-07 13:30:50 UTC) #4
Torne
LGTM, I'll be able to import that from git with some trickery.
7 years, 7 months ago (2013-05-07 14:51:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/14669003/15001
7 years, 7 months ago (2013-05-24 12:25:29 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-24 12:25:45 UTC) #7
Message was sent while issue was closed.
Change committed as 202067

Powered by Google App Engine
This is Rietveld 408576698