Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: Source/core/frame/SettingsDelegate.h

Issue 146683003: Settings should not call into inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: incorporated review comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/Settings.in ('k') | Source/core/inspector/InspectorController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/SettingsDelegate.h
diff --git a/Source/core/frame/SettingsDelegate.h b/Source/core/frame/SettingsDelegate.h
index 2ea0bf2fe07957bb2a6a1c91506b9b9dca051270..ee9e07d9d24a57a84578771cda9182252a3a8f1b 100644
--- a/Source/core/frame/SettingsDelegate.h
+++ b/Source/core/frame/SettingsDelegate.h
@@ -56,14 +56,11 @@ public:
MultisamplingChange,
ImageLoadingChange,
TextAutosizingChange,
+ ScriptEnableChange,
};
virtual void settingsChanged(ChangeType) = 0;
- // FIXME: This is a hack until the Inspector code can
- // be removed from Settings. http://crbug.com/327476
- virtual Page* page() = 0;
-
protected:
OwnPtr<Settings> const m_settings;
};
« no previous file with comments | « Source/core/frame/Settings.in ('k') | Source/core/inspector/InspectorController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698