Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: Source/core/frame/Settings.cpp

Issue 146683003: Settings should not call into inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: incorporated review comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/Settings.h ('k') | Source/core/frame/Settings.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/Settings.cpp
diff --git a/Source/core/frame/Settings.cpp b/Source/core/frame/Settings.cpp
index b7d8d76b6ab41ad056b74efc08d75e7b77a8dd37..fa080bd2b67a83dd22c72caffecf908247ecbc07 100644
--- a/Source/core/frame/Settings.cpp
+++ b/Source/core/frame/Settings.cpp
@@ -26,7 +26,6 @@
#include "config.h"
#include "core/frame/Settings.h"
-#include "core/inspector/InspectorInstrumentation.h"
#include "platform/scroll/ScrollbarTheme.h"
namespace WebCore {
@@ -65,7 +64,7 @@ static const bool defaultSelectTrailingWhitespaceEnabled = false;
#endif
Settings::Settings()
- : m_deviceScaleAdjustment(1.0f)
+ : m_openGLMultisamplingEnabled(false)
#if HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP
, m_textAutosizingWindowSizeOverride(320, 480)
, m_textAutosizingEnabled(true)
@@ -73,8 +72,6 @@ Settings::Settings()
, m_textAutosizingEnabled(false)
#endif
SETTINGS_INITIALIZER_LIST
- , m_isScriptEnabled(false)
- , m_openGLMultisamplingEnabled(false)
{
}
@@ -96,14 +93,6 @@ void Settings::invalidate(SettingsDelegate::ChangeType changeType)
m_delegate->settingsChanged(changeType);
}
-// This is a total hack and should be removed.
-Page* Settings::pageOfShame() const
-{
- if (!m_delegate)
- return 0;
- return m_delegate->page();
-}
-
void Settings::setTextAutosizingEnabled(bool textAutosizingEnabled)
{
if (m_textAutosizingEnabled == textAutosizingEnabled)
@@ -113,11 +102,6 @@ void Settings::setTextAutosizingEnabled(bool textAutosizingEnabled)
invalidate(SettingsDelegate::StyleChange);
}
-bool Settings::textAutosizingEnabled() const
-{
- return InspectorInstrumentation::overrideTextAutosizing(pageOfShame(), m_textAutosizingEnabled);
-}
-
// FIXME: Move to Settings.in once make_settings can understand IntSize.
void Settings::setTextAutosizingWindowSizeOverride(const IntSize& textAutosizingWindowSizeOverride)
{
@@ -128,23 +112,6 @@ void Settings::setTextAutosizingWindowSizeOverride(const IntSize& textAutosizing
invalidate(SettingsDelegate::StyleChange);
}
-void Settings::setDeviceScaleAdjustment(float deviceScaleAdjustment)
-{
- m_deviceScaleAdjustment = deviceScaleAdjustment;
- invalidate(SettingsDelegate::TextAutosizingChange);
-}
-
-float Settings::deviceScaleAdjustment() const
-{
- return InspectorInstrumentation::overrideFontScaleFactor(pageOfShame(), m_deviceScaleAdjustment);
-}
-
-void Settings::setScriptEnabled(bool isScriptEnabled)
-{
- m_isScriptEnabled = isScriptEnabled;
- InspectorInstrumentation::scriptsEnabled(pageOfShame(), m_isScriptEnabled);
-}
-
void Settings::setMockScrollbarsEnabled(bool flag)
{
ScrollbarTheme::setMockScrollbarsEnabled(flag);
« no previous file with comments | « Source/core/frame/Settings.h ('k') | Source/core/frame/Settings.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698