Source/core/page/Page.h - Issue 146683003: Settings should not call into inspector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/Page.h

Issue 146683003: Settings should not call into inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase & incorporated review comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/Page.h

diff --git a/Source/core/page/Page.h b/Source/core/page/Page.h

index a92b5daa8144e7df2884d292a4849566242db404..78eeb5ac0f1ae43ed7eab4df0d5cba452d339c6b 100644

--- a/Source/core/page/Page.h

+++ b/Source/core/page/Page.h

@@ -247,7 +247,6 @@ private:

void setTimerAlignmentInterval(double);

// SettingsDelegate overrides.

- virtual Page* page() OVERRIDE { return this; }

virtual void settingsChanged(SettingsDelegate::ChangeType) OVERRIDE;

const OwnPtr<AutoscrollController> m_autoscrollController;