Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: Source/core/frame/SettingsDelegate.h

Issue 146683003: Settings should not call into inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: incorporated review comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/Settings.in ('k') | Source/core/inspector/InspectorController.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 // We currently use an enum instead of individual invalidation 49 // We currently use an enum instead of individual invalidation
50 // functions to make generating Settings.in slightly easier. 50 // functions to make generating Settings.in slightly easier.
51 enum ChangeType { 51 enum ChangeType {
52 StyleChange, 52 StyleChange,
53 ViewportDescriptionChange, 53 ViewportDescriptionChange,
54 MediaTypeChange, 54 MediaTypeChange,
55 DNSPrefetchingChange, 55 DNSPrefetchingChange,
56 MultisamplingChange, 56 MultisamplingChange,
57 ImageLoadingChange, 57 ImageLoadingChange,
58 TextAutosizingChange, 58 TextAutosizingChange,
59 ScriptEnableChange,
59 }; 60 };
60 61
61 virtual void settingsChanged(ChangeType) = 0; 62 virtual void settingsChanged(ChangeType) = 0;
62 63
63 // FIXME: This is a hack until the Inspector code can
64 // be removed from Settings. http://crbug.com/327476
65 virtual Page* page() = 0;
66
67 protected: 64 protected:
68 OwnPtr<Settings> const m_settings; 65 OwnPtr<Settings> const m_settings;
69 }; 66 };
70 67
71 } // namespace WebCore 68 } // namespace WebCore
72 69
73 #endif // SettingsDelegate_h 70 #endif // SettingsDelegate_h
OLDNEW
« no previous file with comments | « Source/core/frame/Settings.in ('k') | Source/core/inspector/InspectorController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698