src/v8natives.js - Issue 14668013: Function constructor should avoid String.prototype methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/v8natives.js

Issue 14668013: Function constructor should avoid String.prototype methods (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Use %_CallFunction instead of .call Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/v8natives.js

diff --git a/src/v8natives.js b/src/v8natives.js

index db9213215f7514fd78f767dc60a660e260c63170..43d72cd59c634be2fe464cf86c6f43bd3f650be3 100644

--- a/src/v8natives.js

+++ b/src/v8natives.js

@@ -1767,7 +1767,8 @@ function NewFunction(arg1) { // length == 1

// If the formal parameters string include ) - an illegal

// character - it may make the combined function expression

// compile. We avoid this problem by checking for this early on.

- if (p.indexOf(')') != -1) throw MakeSyntaxError('paren_in_arg_string',[]);

+ if (%_CallFunction(p, ')', StringIndexOf) != -1)

+ throw MakeSyntaxError('paren_in_arg_string',[]);

Michael Starzinger 2013/05/15 10:41:18 nit: Either add curly braces around the body or in

// If the formal parameters include an unbalanced block comment, the

// function must be rejected. Since JavaScript does not allow nested

// comments we can include a trailing block comment to catch this.

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-2686.js » ('j') | no next file with comments »