Issue 14668013: Function constructor should avoid String.prototype methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14668013: Function constructor should avoid String.prototype methods (Closed)

Created:
7 years, 7 months ago by wingo

Modified:
7 years, 7 months ago

Reviewers:
Michael Starzinger

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Function constructor should avoid String.prototype methods Replace a use of .indexOf with a call to StringIndexOf. As always, lexical scoping to the rescue. R=mstarzinger@chromium.org TEST=mjsunit/regress/regress-2686 BUG=v8:2686 Committed: 14678

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use %_CallFunction instead of .call #

Total comments: 1

Patch Set 3 : Fix nit #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -13 lines)			Patch
	M	src/v8natives.js	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
	A +	test/mjsunit/regress/regress-2686.js	View		1 chunk	+4 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wingo

https://codereview.chromium.org/14668013/diff/1/src/v8natives.js File src/v8natives.js (right): https://codereview.chromium.org/14668013/diff/1/src/v8natives.js#newcode1770 src/v8natives.js:1770: if (StringIndexOf.call(p, ')') != -1) This just trades one ...

7 years, 7 months ago (2013-05-14 15:43:26 UTC) #2

Michael Starzinger

LGTM with a nit. https://codereview.chromium.org/14668013/diff/2002/src/v8natives.js File src/v8natives.js (right): https://codereview.chromium.org/14668013/diff/2002/src/v8natives.js#newcode1771 src/v8natives.js:1771: throw MakeSyntaxError('paren_in_arg_string',[]); nit: Either add ...

7 years, 7 months ago (2013-05-15 10:41:18 UTC) #3

wingo

7 years, 7 months ago (2013-05-15 10:52:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r14678 (presubmit successful).

Expand Messages | Collapse Messages