Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 14668011: Merge 199665 "Return caret bounds in local coordinates from GetC..." (Closed)

Created:
7 years, 7 months ago by Seigo Nonaka
Modified:
7 years, 7 months ago
Reviewers:
yukawa
CC:
chromium-reviews, nona+watch_chromium.org, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Merge 199665 "Return caret bounds in local coordinates from GetC..." > Return caret bounds in local coordinates from GetCaretBoundsInWidget > > This is another regression caused by r197858. > There remains another call site of TextInputClient::GetCaretBounds, > which now returns the caret rect as screen coordinate as > documented in the header. > > BUG=239737 > TEST=Manually done on Windows 7 with built-in Chinese IME. > > Review URL: https://chromiumcodereview.appspot.com/14731011 TBR=Yukawa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199682

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ui/views/ime/input_method_base.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Seigo Nonaka
7 years, 7 months ago (2013-05-13 07:29:54 UTC) #1
Seigo Nonaka
7 years, 7 months ago (2013-05-13 07:30:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r199682.

Powered by Google App Engine
This is Rietveld 408576698