Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 14668003: Factor out a base class from RuntimeFeatureWriter (Closed)

Created:
7 years, 7 months ago by abarth-chromium
Modified:
7 years, 7 months ago
Reviewers:
eseidel
CC:
blink-reviews
Visibility:
Public.

Description

Factor out a base class from RuntimeFeatureWriter This base class will be used by other in-file based generators to avoid needing to copy/paste boilerplate code. R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149465

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use the class-level constant #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -53 lines) Patch
M Source/core/core.gyp/core_derived_sources.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A Source/core/scripts/in_generator.py View 1 chunk +89 lines, -0 lines 0 comments Download
M Source/core/scripts/make_runtime_features.py View 1 6 chunks +17 lines, -53 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eseidel
lgtm I don't think we know enough about what we're going to need to abstract ...
7 years, 7 months ago (2013-04-30 21:07:29 UTC) #1
abarth-chromium
https://codereview.chromium.org/14668003/diff/1/Source/core/scripts/in_generator.py File Source/core/scripts/in_generator.py (right): https://codereview.chromium.org/14668003/diff/1/Source/core/scripts/in_generator.py#newcode37 Source/core/scripts/in_generator.py:37: class_name = None On 2013/04/30 21:07:29, Eric Seidel (Google) ...
7 years, 7 months ago (2013-04-30 21:09:41 UTC) #2
abarth-chromium
Updated to use the class-level constant. On 2013/04/30 21:07:29, Eric Seidel (Google) wrote: > I ...
7 years, 7 months ago (2013-04-30 21:13:29 UTC) #3
abarth-chromium
7 years, 7 months ago (2013-04-30 21:13:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r149465 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698