Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 1466773002: Make ImageBitmap::cropImage a static function. (Closed)

Created:
5 years, 1 month ago by jbroman
Modified:
5 years, 1 month ago
Reviewers:
Justin Novosad
CC:
blink-reviews, chromium-reviews, xidachen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ImageBitmap::cropImage a static function. It doesn't access any members of ImageBitmap, nor is it called in any other source file. Committed: https://crrev.com/750a86605e5d15b0ae06d62c42a4f2318597f6e3 Cr-Commit-Position: refs/heads/master@{#361005}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -28 lines) Patch
M third_party/WebKit/Source/core/frame/ImageBitmap.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 3 chunks +25 lines, -26 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbroman
Was skimming some ImageBitmap code; wondered how cropping an SkImage relied on members of ImageBitmap. ...
5 years, 1 month ago (2015-11-20 19:52:44 UTC) #2
Justin Novosad
+cc xidachen lgtm
5 years, 1 month ago (2015-11-21 03:52:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466773002/1
5 years, 1 month ago (2015-11-21 04:27:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-21 04:32:23 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-21 04:33:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/750a86605e5d15b0ae06d62c42a4f2318597f6e3
Cr-Commit-Position: refs/heads/master@{#361005}

Powered by Google App Engine
This is Rietveld 408576698