Issue 1466743004: DevTools: local storage view is cloned upon each selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1466743004: DevTools: local storage view is cloned upon each selection. (Closed)

Created:
5 years, 1 month ago by pfeldman

Modified:
5 years, 1 month ago

Reviewers:
caseq

CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

DevTools: local storage view is cloned upon each selection. BUG=558724 Committed: https://crrev.com/7c5eb7fbb0497a596a838dc99c620ebfbb9fc227 Cr-Commit-Position: refs/heads/master@{#360998}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466743004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466743004/1

5 years, 1 month ago (2015-11-21 00:24:09 UTC) #5

commit-bot: I haz the power

5 years, 1 month ago (2015-11-21 03:54:08 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/7c5eb7fbb0497a596a838dc99c620ebfbb9fc227
Cr-Commit-Position: refs/heads/master@{#360998}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages