Issue 1466743003: Merge to XFA: Replace |CPWL_ComboBox::operator CPWL_Edit()|.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1466743003: Merge to XFA: Replace |CPWL_ComboBox::operator CPWL_Edit()|. (Closed)

Created:
5 years, 1 month ago by Tom Sepez

Modified:
5 years ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Replace |CPWL_ComboBox::operator CPWL_Edit()|. Original Review URL: https://codereview.chromium.org/1467653002 . (cherry picked from commit 54bc568bb41c5c258e95c24ef9d7355dcdc20f9e) R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/b4f00291e3dbf0b067fd8e1c40194a5a30d89b1f

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -15 lines)			Patch
	M	fpdfsdk/include/pdfwindow/PWL_ComboBox.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	fpdfsdk/src/formfiller/FFL_ComboBox.cpp	View	1	6 chunks	+12 lines, -14 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

5 years ago (2015-11-23 17:13:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
b4f00291e3dbf0b067fd8e1c40194a5a30d89b1f (presubmit successful).