Google OAuth Device Flow support for FNL

services/authentication/google_authentication_impl.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SERVICES_AUTHENTICATION_GOOGLE_AUTHENTICATION_IMPL_H_
+#define SERVICES_AUTHENTICATION_GOOGLE_AUTHENTICATION_IMPL_H_
+
+#include "base/memory/weak_ptr.h"
+#include "mojo/common/binding_set.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
+#include "mojo/public/cpp/system/macros.h"
+#include "mojo/services/authentication/interfaces/authentication.mojom.h"
+#include "mojo/services/network/interfaces/network_service.mojom.h"
+#include "services/authentication/accounts_db_manager.h"
+
+namespace authentication {
+
+// Implementation of AuthenticationService from
+// services/authentication/authentication.mojom for Google users.
+class GoogleAuthenticationServiceImpl
+    : public authentication::AuthenticationService {
+ public:
+  GoogleAuthenticationServiceImpl(
+      mojo::InterfaceRequest<AuthenticationService> request,
+      const mojo::String app_url,
+      mojo::NetworkServicePtr& network_service,
+      mojo::files::DirectoryPtr& directory);
+
+  ~GoogleAuthenticationServiceImpl() override;
+
+  void GetOAuth2Token(const mojo::String& username,
+                      mojo::Array<mojo::String> scopes,
+                      const GetOAuth2TokenCallback& callback) override;
+
+  void SelectAccount(bool returnLastSelected,
+                     const SelectAccountCallback& callback) override;
+
+  void ClearOAuth2Token(const mojo::String& token) override;
+
+  void GetOAuth2DeviceCode(
+      mojo::Array<mojo::String> scopes,
+      const GetOAuth2DeviceCodeCallback& callback) override;
+
+  void AddAccount(const mojo::String& device_code,
+                  const AddAccountCallback& callback) override;
+
+ private:
+  // Polls recursively for user grant authorized on secondary device and
+  // on success, adds the user account to the credentials database and returns
+  // the username. On error, an error description is returned.
+  void AddAccount(const mojo::String& device_code,
+                  const uint32_t num_poll_attempts,
+                  const AddAccountCallback& callback);
+
+  void OnGetOAuth2Token(const GetOAuth2TokenCallback& callback,
+                        const std::string& response,
+                        const std::string& error);
+
+  void OnGetOAuth2DeviceCode(const GetOAuth2DeviceCodeCallback& callback,
+                             const std::string& response,
+                             const std::string& error);
+
+  // Fetches token info from access token.
+  void GetTokenInfo(const std::string& access_token);
+
+  void OnGetTokenInfo(const std::string& response, const std::string& error);
+
+  // Fetches user info from id token.
+  void GetUserInfo(const std::string& id_token);
+
+  void OnGetUserInfo(const std::string& response, const std::string& error);
+
+  void OnAddAccount(const AddAccountCallback& callback,
+                    const mojo::String& device_code,
+                    const uint32_t num_poll_attempts,
+                    const std::string& response,
+                    const std::string& error);
+
+  void Request(const std::string& url,
+               const std::string& method,
+               const std::string& message,
+               const GetOAuth2TokenCallback& callback);
+
+  void Request(const std::string& url,
+               const std::string& method,
+               const std::string& message,
+               const GetOAuth2TokenCallback& callback,
+               const mojo::String& device_code,
+               const uint32_t num_poll_attempts);
+
+  void HandleServerResponse(const GetOAuth2TokenCallback& callback,
+                            const mojo::String& device_code,
+                            const uint32_t num_poll_attempts,
+                            mojo::URLResponsePtr response);
+
+  std::string user_id_;
+  std::string email_;
+  std::string scope_;
+  mojo::StrongBinding<AuthenticationService> binding_;
+  std::string app_url_;
+  mojo::NetworkServicePtr& network_service_;
+  AccountsDbManager* accounts_db_manager_;

[qsr, 2016/02/16 14:17:06]

Your account db manager have a tendency to delete itself on all kind of errors.
How to we prevent crashes if that happens?

[ukode, 2016/02/26 21:35:50]

Made it as a weak ptr, and checking if it still exists before every operation.

+  base::WeakPtrFactory<GoogleAuthenticationServiceImpl> weak_ptr_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(GoogleAuthenticationServiceImpl);
+};
+
+}  // namespace authentication
+
+#endif  // SERVICES_AUTHENTICATION_GOOGLE_AUTHENTICATION_IMPL_H_