Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1466713002: Initialize memory for BitMask and Clip test. (Closed)

Created:
5 years, 1 month ago by herb_g
Modified:
5 years, 1 month ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Initialize memory for BitMask and Clip test. BUG=skia: Committed: https://skia.googlesource.com/skia/+/1ac026d71c4637622138adcbfa320e41e61bde53

Patch Set 1 #

Total comments: 4

Patch Set 2 : change to memset. #

Patch Set 3 : get includes right #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tests/BlitMaskClip.cpp View 1 2 3 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
herb_g
5 years, 1 month ago (2015-11-20 16:50:08 UTC) #3
bungeman-skia
https://codereview.chromium.org/1466713002/diff/1/tests/BlitMaskClip.cpp File tests/BlitMaskClip.cpp (right): https://codereview.chromium.org/1466713002/diff/1/tests/BlitMaskClip.cpp#newcode10 tests/BlitMaskClip.cpp:10: #include "SkUtils.h" Is there a reason for adding this? ...
5 years, 1 month ago (2015-11-20 16:55:37 UTC) #4
herb_g
change to memset.
5 years, 1 month ago (2015-11-20 17:01:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466713002/20001
5 years, 1 month ago (2015-11-20 17:05:14 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 1 month ago (2015-11-20 17:05:16 UTC) #8
herb_g
get includes right
5 years, 1 month ago (2015-11-20 17:09:24 UTC) #9
herb_g
PTAL https://codereview.chromium.org/1466713002/diff/1/tests/BlitMaskClip.cpp File tests/BlitMaskClip.cpp (right): https://codereview.chromium.org/1466713002/diff/1/tests/BlitMaskClip.cpp#newcode10 tests/BlitMaskClip.cpp:10: #include "SkUtils.h" On 2015/11/20 16:55:36, bungeman1 wrote: > ...
5 years, 1 month ago (2015-11-20 17:11:10 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466713002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466713002/40001
5 years, 1 month ago (2015-11-20 17:11:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466713002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466713002/40001
5 years, 1 month ago (2015-11-20 18:04:46 UTC) #15
bungeman-skia
lgtm
5 years, 1 month ago (2015-11-20 18:05:06 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 21:37:39 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/1ac026d71c4637622138adcbfa320e41e61bde53

Powered by Google App Engine
This is Rietveld 408576698