sync: Better iteration in GenericChangeProcessor

sync/internal_api/public/base_node.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SYNC_INTERNAL_API_PUBLIC_BASE_NODE_H_
 #define SYNC_INTERNAL_API_PUBLIC_BASE_NODE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 173 matching lines @@
   int64 GetPredecessorId() const;
 
   // Return the ID of the node immediately after this in the sibling order.
   // For the last node in the ordering, return 0.
   int64 GetSuccessorId() const;
 
   // Return the ID of the first child of this node.  If this node has no
   // children, return 0.
   int64 GetFirstChildId() const;
 
+  // Returns an ordered list of the children of this node.

[Nicolas Zea, 2013/05/22 22:34:02]

nit: mention what the order is?

[rlarocque, 2013/05/23 00:39:39]

Done.

+  void GetChildIds(std::vector<int64>* result) const;
+
   // Returns the total number of nodes including and beneath this node.
   // Recursively iterates through all children.
   int GetTotalNodeCount() const;
 
   // These virtual accessors provide access to data members of derived classes.
   virtual const syncable::Entry* GetEntry() const = 0;
   virtual const BaseTransaction* GetTransaction() const = 0;
 
   // Dumps a summary of node info into a DictionaryValue and returns it.
   // Transfers ownership of the DictionaryValue to the caller.
@@ skipping 48 matching lines @@
 
   // Same as |unencrypted_data_|, but for legacy password encryption.
   scoped_ptr<sync_pb::PasswordSpecificsData> password_data_;
 
   DISALLOW_COPY_AND_ASSIGN(BaseNode);
 };
 
 }  // namespace syncer
 
 #endif  // SYNC_INTERNAL_API_PUBLIC_BASE_NODE_H_