Issue 14667012: Merge 198866 "Move post-signin confirmation bubble to OneClickSi..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14667012: Merge 198866 "Move post-signin confirmation bubble to OneClickSi..." (Closed)

Created:
7 years, 7 months ago by Andrew T Wilson (Slow)

Modified:
7 years, 7 months ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/branches/1500/src/

Visibility:
Public.

Merge 198866 "Move post-signin confirmation bubble to OneClickSi..." > Move post-signin confirmation bubble to OneClickSigninSyncStarter. > > OneClickSigninSyncStarter now displays the post-signin confirmation bubble so > we can better integrate this with the rest of the signin UI (creating a new > profile, displaying the SAML dialog, etc). > > BUG=174655, 232339, 236828, 238173 > R=rogerta@chromium.org > > Review URL: https://codereview.chromium.org/14914003 TBR=atwilson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199943

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+188 lines, -142 lines)			Patch
M	chrome/browser/ui/sync/one_click_signin_helper.h	View	6 chunks	+4 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_helper.cc	View	17 chunks	+91 lines, -102 lines	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_sync_starter.h	View	3 chunks	+29 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_sync_starter.cc	View	9 chunks	+64 lines, -22 lines	0 comments	Download

Total messages: 2 (0 generated)

Andrew T Wilson (Slow)

7 years, 7 months ago (2013-05-14 07:20:48 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r199943.