Issue 14667011: Merge 199398 "Revert r196089 "Add default values for Latin scrip..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14667011: Merge 199398 "Revert r196089 "Add default values for Latin scrip..." (Closed)

Created:
7 years, 7 months ago by falken

Modified:
7 years, 7 months ago

Reviewers:
falken

CC:
chromium-reviews, finnur+watch_chromium.org, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1500/src/

Visibility:
Public.

More Reviews

Description

Merge 199398 "Revert r196089 "Add default values for Latin scrip..." > Revert r196089 "Add default values for Latin script font prefs." > > Reverting because it caused bug 237258. Many sites set lang="en" > which cause the Latin font prefs to be used, and it's surprising > to users that chrome://settings/fonts is not respected. We need > a more obvious way to customize per-script fonts first. > > BUG=237258 > TBR=bauerb > > Review URL: https://chromiumcodereview.appspot.com/14877009 TBR=falken@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199941

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -238 lines)			Patch
M	chrome/app/resources/locale_settings_chromiumos.grd	View	1 chunk	+0 lines, -42 lines	0 comments	Download
M	chrome/app/resources/locale_settings_google_chromeos.grd	View	1 chunk	+0 lines, -42 lines	0 comments	Download
M	chrome/app/resources/locale_settings_linux.grd	View	1 chunk	+0 lines, -42 lines	0 comments	Download
M	chrome/app/resources/locale_settings_mac.grd	View	1 chunk	+0 lines, -42 lines	0 comments	Download
M	chrome/app/resources/locale_settings_win.grd	View	1 chunk	+0 lines, -42 lines	0 comments	Download
M	chrome/browser/ui/prefs/prefs_tab_helper.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r199941.

Expand Messages | Collapse Messages