Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/compiler/verifier.cc

Issue 1466643002: [turbofan] Initial support for Array constructor specialization. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed Michi's comments. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 493 matching lines...) Expand 10 before | Expand all | Expand 10 after
504 break; 504 break;
505 505
506 case IrOpcode::kJSCreate: 506 case IrOpcode::kJSCreate:
507 // Type is Object. 507 // Type is Object.
508 CheckUpperIs(node, Type::Object()); 508 CheckUpperIs(node, Type::Object());
509 break; 509 break;
510 case IrOpcode::kJSCreateArguments: 510 case IrOpcode::kJSCreateArguments:
511 // Type is OtherObject. 511 // Type is OtherObject.
512 CheckUpperIs(node, Type::OtherObject()); 512 CheckUpperIs(node, Type::OtherObject());
513 break; 513 break;
514 case IrOpcode::kJSCreateArray:
515 // Type is OtherObject.
516 CheckUpperIs(node, Type::OtherObject());
517 break;
514 case IrOpcode::kJSCreateClosure: 518 case IrOpcode::kJSCreateClosure:
515 // Type is Function. 519 // Type is Function.
516 CheckUpperIs(node, Type::OtherObject()); 520 CheckUpperIs(node, Type::OtherObject());
517 break; 521 break;
518 case IrOpcode::kJSCreateLiteralArray: 522 case IrOpcode::kJSCreateLiteralArray:
519 case IrOpcode::kJSCreateLiteralObject: 523 case IrOpcode::kJSCreateLiteralObject:
520 // Type is OtherObject. 524 // Type is OtherObject.
521 CheckUpperIs(node, Type::OtherObject()); 525 CheckUpperIs(node, Type::OtherObject());
522 break; 526 break;
523 case IrOpcode::kJSLoadProperty: 527 case IrOpcode::kJSLoadProperty:
(...skipping 14 matching lines...) Expand all
538 // Type is Boolean. 542 // Type is Boolean.
539 CheckUpperIs(node, Type::Boolean()); 543 CheckUpperIs(node, Type::Boolean());
540 break; 544 break;
541 case IrOpcode::kJSTypeOf: 545 case IrOpcode::kJSTypeOf:
542 // Type is String. 546 // Type is String.
543 CheckUpperIs(node, Type::String()); 547 CheckUpperIs(node, Type::String());
544 break; 548 break;
545 549
546 case IrOpcode::kJSLoadContext: 550 case IrOpcode::kJSLoadContext:
547 case IrOpcode::kJSLoadDynamic: 551 case IrOpcode::kJSLoadDynamic:
552 case IrOpcode::kJSLoadNativeContext:
548 // Type can be anything. 553 // Type can be anything.
549 CheckUpperIs(node, Type::Any()); 554 CheckUpperIs(node, Type::Any());
550 break; 555 break;
551 case IrOpcode::kJSStoreContext: 556 case IrOpcode::kJSStoreContext:
552 // Type is empty. 557 // Type is empty.
553 CheckNotTyped(node); 558 CheckNotTyped(node);
554 break; 559 break;
555 case IrOpcode::kJSCreateFunctionContext: 560 case IrOpcode::kJSCreateFunctionContext:
556 case IrOpcode::kJSCreateCatchContext: 561 case IrOpcode::kJSCreateCatchContext:
557 case IrOpcode::kJSCreateWithContext: 562 case IrOpcode::kJSCreateWithContext:
(...skipping 684 matching lines...) Expand 10 before | Expand all | Expand 10 after
1242 replacement->op()->EffectOutputCount() > 0); 1247 replacement->op()->EffectOutputCount() > 0);
1243 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1248 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1244 replacement->opcode() == IrOpcode::kFrameState); 1249 replacement->opcode() == IrOpcode::kFrameState);
1245 } 1250 }
1246 1251
1247 #endif // DEBUG 1252 #endif // DEBUG
1248 1253
1249 } // namespace compiler 1254 } // namespace compiler
1250 } // namespace internal 1255 } // namespace internal
1251 } // namespace v8 1256 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698