Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1466633004: Fix flags for Chromecast browser test on internal infrastructure (Closed)

Created:
5 years, 1 month ago by halliwell
Modified:
5 years, 1 month ago
Reviewers:
slan, Simeon
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flags for Chromecast browser test on internal infrastructure The media playback test was recently added: https://codereview.chromium.org/1431193005/ and requires specific switches: * local file access required to load test media * cma pipeline explicitly enabled in order to test that * cast ozone platform enabled in order to test overlay frames These tests have been failing on internal infrastructure (tot build) because the switches were only configured in testing/buildbot (for running on Chromium bots). BUG= Committed: https://crrev.com/146527ab5e3cf1f54dc36f4d1d06d7db9cfc913b Cr-Commit-Position: refs/heads/master@{#361134}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chromecast/BUILD.gn View 1 chunk +1 line, -1 line 1 comment Download
M chromecast/chromecast_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
halliwell
5 years, 1 month ago (2015-11-21 02:52:18 UTC) #3
slan
lgtm https://codereview.chromium.org/1466633004/diff/1/chromecast/BUILD.gn File chromecast/BUILD.gn (left): https://codereview.chromium.org/1466633004/diff/1/chromecast/BUILD.gn#oldcode111 chromecast/BUILD.gn:111: filters += [ "cast_shell_browser_test --no-sandbox --disable-gpu" ] no ...
5 years, 1 month ago (2015-11-21 02:58:32 UTC) #4
halliwell
On 2015/11/21 02:58:32, slan wrote: > lgtm > > https://codereview.chromium.org/1466633004/diff/1/chromecast/BUILD.gn > File chromecast/BUILD.gn (left): > ...
5 years, 1 month ago (2015-11-21 03:11:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466633004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466633004/1
5 years, 1 month ago (2015-11-23 17:12:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 17:47:37 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 17:48:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/146527ab5e3cf1f54dc36f4d1d06d7db9cfc913b
Cr-Commit-Position: refs/heads/master@{#361134}

Powered by Google App Engine
This is Rietveld 408576698