Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1466633003: Revert of ipc: Add basic memory usage tests for attachment brokering. (Closed)

Created:
5 years, 1 month ago by dcheng
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ipc: Add basic memory usage tests for attachment brokering. (patchset #4 id:60001 of https://codereview.chromium.org/1465623002/ ) Reason for revert: Failing on Mac ASan 64 Tests (1) Original issue's description: > ipc: Add basic memory usage tests for attachment brokering. > > I added two tests for memory leaks in the attachment brokering process. The > first checks memory usage after brokering a single, large, shared memory object. > The second checks memory usage after brokering a thousand, smaller memory > objects. > > BUG=557387 > > Committed: https://crrev.com/a519e56d03e1f6d69b7475bdd006f5e47b4f581e > Cr-Commit-Position: refs/heads/master@{#360935} TBR=tsepez@chromium.org,mark@chromium.org,erikchen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=557387 Committed: https://crrev.com/0d27e6d351f825bc1f9d1483c44ddb3626a93580 Cr-Commit-Position: refs/heads/master@{#360991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -169 lines) Patch
M ipc/attachment_broker_mac_unittest.cc View 8 chunks +3 lines, -169 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
Created Revert of ipc: Add basic memory usage tests for attachment brokering.
5 years, 1 month ago (2015-11-21 02:45:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466633003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466633003/1
5 years, 1 month ago (2015-11-21 02:46:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-21 02:48:16 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-21 02:49:06 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d27e6d351f825bc1f9d1483c44ddb3626a93580
Cr-Commit-Position: refs/heads/master@{#360991}

Powered by Google App Engine
This is Rietveld 408576698