Issue 1466623002: Convert into block documentation comment assist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1466623002: Convert into block documentation comment assist. (Closed)

Created:
5 years, 1 month ago by scheglov

Modified:
5 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Convert into block documentation comment assist. I found out that I don't like the /// style. So, I'm going to convert the Angular2 analysis plugins to the block style. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2b59830f49526ae9643bd6e7b7f2d3427f99f778

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+96 lines, -7 lines)			Patch
M	pkg/analysis_server/lib/src/services/correction/assist.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/assist_internal.dart	View	5 chunks	+33 lines, -6 lines	0 comments	Download
M	pkg/analysis_server/test/services/correction/assist_test.dart	View	2 chunks	+59 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

Committed patchset #1 (id:1) manually as 2b59830f49526ae9643bd6e7b7f2d3427f99f778 (presubmit successful).

5 years, 1 month ago (2015-11-20 16:11:33 UTC) #3

kevmoo

5 years, 1 month ago (2015-11-20 17:27:54 UTC) #4

Message was sent while issue was closed.

On 2015/11/20 16:11:33, scheglov wrote:
> Committed patchset #1 (id:1) manually as
> 2b59830f49526ae9643bd6e7b7f2d3427f99f778 (presubmit successful).

We've been actually telling folks to move AWAY from /**  */ towards ///

https://www.dartlang.org/effective-dart/documentation/#do-use--doc-comments-t...

Expand Messages | Collapse Messages