Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl

Issue 1466563003: Make [TypeChecking=Interface] the default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl
diff --git a/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl b/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl
index 658e8b8a30516e20dd91906f2c809cac96315dd3..60e0ba9a49a03cfbb3a01f5b365f75e9706a51a8 100644
--- a/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl
+++ b/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl
@@ -82,7 +82,7 @@ enum RTCIceConnectionState {
// readonly attribute RTCSessionDescription? currentRemoteDescription;
// readonly attribute RTCSessionDescription? pendingRemoteDescription;
// TODO(guidou): addIceCandidate() should return a Promise.
- [RaisesException] void addIceCandidate(RTCIceCandidate candidate);
+ [RaisesException, LegacyInterfaceTypeChecking] void addIceCandidate(RTCIceCandidate candidate);
readonly attribute RTCSignalingState signalingState;
readonly attribute RTCIceGatheringState iceGatheringState;
readonly attribute RTCIceConnectionState iceConnectionState;
@@ -101,18 +101,18 @@ enum RTCIceConnectionState {
// TODO(guidou): The failureCallback argument should be non-optional.
[RaisesException] void createOffer(RTCSessionDescriptionCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback, optional Dictionary rtcOfferOptions);
// TODO(guidou): None of the arguments should be optional.
- [RaisesException] void setLocalDescription(RTCSessionDescription description, [Default=Undefined] optional VoidCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback);
+ [RaisesException, LegacyInterfaceTypeChecking] void setLocalDescription(RTCSessionDescription description, [Default=Undefined] optional VoidCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback);
// TODO(guidou): The failureCallback argument should be non-optional, and
// there should be no mediaConstraints argument.
[RaisesException] void createAnswer(RTCSessionDescriptionCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback, optional Dictionary mediaConstraints);
// TODO(guidou): The successCallback and failureCallback arguments should be
// non-optional.
- [RaisesException] void setRemoteDescription(RTCSessionDescription description, [Default=Undefined] optional VoidCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback);
- [RaisesException] void addIceCandidate(RTCIceCandidate candidate, VoidCallback successCallback, RTCErrorCallback failureCallback);
+ [RaisesException, LegacyInterfaceTypeChecking] void setRemoteDescription(RTCSessionDescription description, [Default=Undefined] optional VoidCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback);
+ [RaisesException, LegacyInterfaceTypeChecking] void addIceCandidate(RTCIceCandidate candidate, VoidCallback successCallback, RTCErrorCallback failureCallback);
// TODO(guidou): The selector argument should the first (nullable,
// non-optional) argument, and there should be a third failureCallback
// argument.
- void getStats(RTCStatsCallback successCallback, [Default=Undefined] optional MediaStreamTrack selector);
+ [LegacyInterfaceTypeChecking] void getStats(RTCStatsCallback successCallback, [Default=Undefined] optional MediaStreamTrack selector);
// https://w3c.github.io/webrtc-pc/#peer-to-peer-data-api
// TODO(guidou): The label argument should have [TreatNullAs=EmptyString]
@@ -125,9 +125,9 @@ enum RTCIceConnectionState {
sequence<MediaStream> getLocalStreams();
sequence<MediaStream> getRemoteStreams();
MediaStream getStreamById(DOMString streamId);
- [TypeChecking=Interface, RaisesException] void addStream(MediaStream? stream, optional Dictionary mediaConstraints);
- [TypeChecking=Interface, RaisesException] void removeStream(MediaStream? stream);
- [RaisesException] RTCDTMFSender createDTMFSender(MediaStreamTrack track);
+ [RaisesException] void addStream(MediaStream? stream, optional Dictionary mediaConstraints);
+ [RaisesException] void removeStream(MediaStream? stream);
+ [RaisesException, LegacyInterfaceTypeChecking] RTCDTMFSender createDTMFSender(MediaStreamTrack track);
attribute EventHandler onaddstream;
attribute EventHandler onremovestream;

Powered by Google App Engine
This is Rietveld 408576698