Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1466543003: Use w3c test harness in editing/selection/vertical-*.html tests 3/3 (Closed)

Created:
5 years, 1 month ago by yosin_UTC9
Modified:
5 years, 1 month ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use w3c test harness in editing/selection/vertical-*.html tests 3/3 This patch makes editing/selection/vertical-*.html to use w3c test harness rather than pixel match for ease of maintain. This is the first patch of three patches of rewriting vertical-*.html. Due by Windows command prompt limitation, we can't upload once. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/72531bf4c6bd3103da47d6e39784b26df512b8d5 Cr-Commit-Position: refs/heads/master@{#361270}

Patch Set 1 : 2015-11-20T17:10:27 #

Total comments: 2

Patch Set 2 : 2015-11-24T12:47:49 #

Patch Set 3 : 2015-11-24T15:09:03 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -347 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/vertical-rl-rtl-extend-line-backward-br.html View 1 1 chunk +17 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/vertical-rl-rtl-extend-line-backward-p.html View 1 chunk +18 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/vertical-rl-rtl-extend-line-forward-br.html View 1 chunk +16 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/vertical-rl-rtl-extend-line-forward-p.html View 1 chunk +17 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
yosin_UTC9
PTAL
5 years, 1 month ago (2015-11-20 08:36:00 UTC) #2
yoichio
https://codereview.chromium.org/1466543003/diff/1/third_party/WebKit/LayoutTests/editing/selection/vertical-rl-rtl-extend-line-backward-br.html File third_party/WebKit/LayoutTests/editing/selection/vertical-rl-rtl-extend-line-backward-br.html (right): https://codereview.chromium.org/1466543003/diff/1/third_party/WebKit/LayoutTests/editing/selection/vertical-rl-rtl-extend-line-backward-br.html#newcode15 third_party/WebKit/LayoutTests/editing/selection/vertical-rl-rtl-extend-line-backward-br.html:15: selection.modify('Extend', 'Forward', 'Line'); 'Backward'?
5 years, 1 month ago (2015-11-24 02:16:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466543003/1
5 years, 1 month ago (2015-11-24 02:17:40 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 1 month ago (2015-11-24 02:17:44 UTC) #7
yosin_UTC9
PTAL https://codereview.chromium.org/1466543003/diff/1/third_party/WebKit/LayoutTests/editing/selection/vertical-rl-rtl-extend-line-backward-br.html File third_party/WebKit/LayoutTests/editing/selection/vertical-rl-rtl-extend-line-backward-br.html (right): https://codereview.chromium.org/1466543003/diff/1/third_party/WebKit/LayoutTests/editing/selection/vertical-rl-rtl-extend-line-backward-br.html#newcode15 third_party/WebKit/LayoutTests/editing/selection/vertical-rl-rtl-extend-line-backward-br.html:15: selection.modify('Extend', 'Forward', 'Line'); On 2015/11/24 at 02:16:35, yoichio ...
5 years, 1 month ago (2015-11-24 03:51:27 UTC) #8
yoichio
lgtm
5 years, 1 month ago (2015-11-24 03:59:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466543003/20001
5 years, 1 month ago (2015-11-24 04:12:53 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/145118)
5 years, 1 month ago (2015-11-24 04:45:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466543003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466543003/40001
5 years, 1 month ago (2015-11-24 06:13:57 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-24 07:20:55 UTC) #17
commit-bot: I haz the power
5 years, 1 month ago (2015-11-24 07:22:06 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/72531bf4c6bd3103da47d6e39784b26df512b8d5
Cr-Commit-Position: refs/heads/master@{#361270}

Powered by Google App Engine
This is Rietveld 408576698