Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 1466493002: Remove unused SpdyTestUtil methods. (Closed)

Created:
5 years, 1 month ago by Bence
Modified:
5 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused SpdyTestUtil methods. Minor SpdyTestUtil cleanup: * Remove unused ChopReadFrame() declaration and definition. * Consolidate the two flavors of ChopWriteFrame(). * Remove unused MakeSpdyHeader() declaration and definition. * Remove undefined ConstructSpdyGetForProxy() declaration. Committed: https://crrev.com/be78f0982260dc950328b24d7beb10b685a26c5a Cr-Commit-Position: refs/heads/master@{#361051}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -76 lines) Patch
M net/spdy/spdy_test_util_common.h View 1 3 chunks +0 lines, -24 lines 0 comments Download
M net/spdy/spdy_test_util_common.cc View 1 2 chunks +6 lines, -52 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Bence
Ryan: PTAL. Thanks.
5 years, 1 month ago (2015-11-20 13:26:48 UTC) #2
Ryan Hamilton
lgtm
5 years, 1 month ago (2015-11-20 23:29:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466493002/1
5 years, 1 month ago (2015-11-21 00:49:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/143833) linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 1 month ago (2015-11-21 01:25:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466493002/20001
5 years, 1 month ago (2015-11-22 20:46:28 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-22 21:09:40 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-22 21:10:19 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/be78f0982260dc950328b24d7beb10b685a26c5a
Cr-Commit-Position: refs/heads/master@{#361051}

Powered by Google App Engine
This is Rietveld 408576698