Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1466483003: Makes window manager include ui pak file (Closed)

Created:
5 years, 1 month ago by sky
Modified:
5 years, 1 month ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, rjkroege, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes window manager include ui pak file We'll need this for cursors and shadows. BUG=548426 TEST=none R=erg@chromium.org Committed: https://crrev.com/35b0cd220fd2a788c16055b756e8483936b0e384 Cr-Commit-Position: refs/heads/master@{#361162}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M components/mus/BUILD.gn View 3 chunks +10 lines, -1 line 0 comments Download
M components/mus/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/mus_app.cc View 4 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
sky
5 years, 1 month ago (2015-11-19 22:31:20 UTC) #1
Elliot Glaysher
lgtm Does this mean that anything in the mus application can use resources now, or ...
5 years, 1 month ago (2015-11-19 22:35:09 UTC) #2
sky
This is the window server side.
5 years, 1 month ago (2015-11-19 22:41:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466483003/1
5 years, 1 month ago (2015-11-23 19:07:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 20:14:54 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/35b0cd220fd2a788c16055b756e8483936b0e384 Cr-Commit-Position: refs/heads/master@{#361162}
5 years, 1 month ago (2015-11-23 20:16:07 UTC) #7
sky
5 years, 1 month ago (2015-11-24 00:11:36 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1472753003/ by sky@chromium.org.

The reason for reverting is: I'm reverting this and will instead include it in
the wm..

Powered by Google App Engine
This is Rietveld 408576698