Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2065)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/app/nibs/HttpAuthLoginSheet.xib

Issue 1466473003: Do not show untrustworthy strings in the basic auth dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Correct Cocoa (update the XIB). Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/android/chrome_http_auth_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/nibs/HttpAuthLoginSheet.xib
diff --git a/chrome/app/nibs/HttpAuthLoginSheet.xib b/chrome/app/nibs/HttpAuthLoginSheet.xib
index 892f959a4b0153b99afd439d453fa0c8d17fbd50..f1a1a00ab08078823fdc54945aa778e76a559f3f 100644
--- a/chrome/app/nibs/HttpAuthLoginSheet.xib
+++ b/chrome/app/nibs/HttpAuthLoginSheet.xib
@@ -1,14 +1,15 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersion="5056" systemVersion="13F34" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none">
+<document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersion="7706" systemVersion="15B42" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none">
<dependencies>
<deployment version="1060" identifier="macosx"/>
<development version="5100" identifier="xcode"/>
- <plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="5056"/>
+ <plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="7706"/>
</dependencies>
<objects>
<customObject id="-2" userLabel="File's Owner" customClass="LoginHandlerSheet">
<connections>
<outlet property="cancelButton_" destination="13" id="47"/>
+ <outlet property="authorityField_" destination="abu-ex-fsZ" id="52"/>
groby-ooo-7-16 2015/11/24 01:41:55 You might want to use a numeric ID - I don't know
palmer 2015/12/01 21:15:21 Done.
<outlet property="explanationField_" destination="41" id="45"/>
<outlet property="loginButton_" destination="11" id="46"/>
<outlet property="nameField_" destination="7" id="21"/>
@@ -17,17 +18,17 @@
</connections>
</customObject>
<customObject id="-1" userLabel="First Responder" customClass="FirstResponder"/>
- <customObject id="-3" userLabel="Application"/>
+ <customObject id="-3" userLabel="Application" customClass="NSObject"/>
groby-ooo-7-16 2015/11/24 01:41:55 Probably want to remove that, not relevant to your
palmer 2015/12/01 21:15:21 Done.
<window title="Window" allowsToolTipsWhenApplicationIsInactive="NO" autorecalculatesKeyViewLoop="NO" oneShot="NO" releasedWhenClosed="NO" showsToolbarButton="NO" visibleAtLaunch="NO" animationBehavior="default" id="1" customClass="ConstrainedWindowCustomWindow">
<windowPositionMask key="initialPositionMask" leftStrut="YES" bottomStrut="YES"/>
- <rect key="contentRect" x="196" y="388" width="400" height="200"/>
+ <rect key="contentRect" x="196" y="388" width="400" height="234"/>
<rect key="screenRect" x="0.0" y="0.0" width="1440" height="878"/>
<view key="contentView" id="2" customClass="ConstrainedWindowCustomWindowContentView">
- <rect key="frame" x="0.0" y="0.0" width="400" height="200"/>
+ <rect key="frame" x="0.0" y="-5" width="400" height="234"/>
<autoresizingMask key="autoresizingMask"/>
<subviews>
<box autoresizesSubviews="NO" transparent="YES" borderType="none" titlePosition="noTitle" id="24">
- <rect key="frame" x="105" y="58" width="283" height="74"/>
+ <rect key="frame" x="105" y="70" width="283" height="74"/>
<autoresizingMask key="autoresizingMask" widthSizable="YES" flexibleMaxY="YES"/>
<view key="contentView">
<rect key="frame" x="0.0" y="0.0" width="283" height="74"/>
@@ -36,6 +37,7 @@
<secureTextField verticalHuggingPriority="750" id="9">
<rect key="frame" x="6" y="10" width="269" height="22"/>
<autoresizingMask key="autoresizingMask" widthSizable="YES" flexibleMinY="YES"/>
+ <animations/>
groby-ooo-7-16 2015/11/24 01:41:55 Kill all the empty <animations/> tags - I suspect
palmer 2015/12/01 21:15:21 Done.
<secureTextFieldCell key="cell" scrollable="YES" lineBreakMode="clipping" selectable="YES" editable="YES" sendsActionOnEndEditing="YES" borderStyle="bezel" drawsBackground="YES" id="10">
<font key="font" metaFont="system"/>
<color key="textColor" name="textColor" catalog="System" colorSpace="catalog"/>
@@ -51,6 +53,7 @@
<textField verticalHuggingPriority="750" id="7">
<rect key="frame" x="6" y="42" width="269" height="22"/>
<autoresizingMask key="autoresizingMask" widthSizable="YES" flexibleMinY="YES"/>
+ <animations/>
<textFieldCell key="cell" scrollable="YES" lineBreakMode="clipping" selectable="YES" editable="YES" sendsActionOnEndEditing="YES" state="on" borderStyle="bezel" drawsBackground="YES" id="8">
<font key="font" metaFont="system"/>
<color key="textColor" name="textColor" catalog="System" colorSpace="catalog"/>
@@ -61,17 +64,20 @@
</connections>
</textField>
</subviews>
+ <animations/>
</view>
+ <animations/>
<color key="borderColor" white="0.0" alpha="0.41999999999999998" colorSpace="calibratedWhite"/>
<color key="fillColor" white="0.0" alpha="0.0" colorSpace="calibratedWhite"/>
</box>
<customView id="33" customClass="GTMWidthBasedTweaker">
- <rect key="frame" x="168" y="8" width="231" height="52"/>
+ <rect key="frame" x="168" y="20" width="231" height="52"/>
groby-ooo-7-16 2015/11/24 01:41:55 Is that size change here deliberate?
<autoresizingMask key="autoresizingMask" flexibleMinX="YES" flexibleMaxY="YES"/>
<subviews>
<button verticalHuggingPriority="750" id="13" customClass="ConstrainedWindowButton">
<rect key="frame" x="10" y="12" width="96" height="32"/>
<autoresizingMask key="autoresizingMask" flexibleMinX="YES" flexibleMaxY="YES"/>
+ <animations/>
<buttonCell key="cell" type="push" title="^IDS_CANCEL" bezelStyle="rounded" alignment="center" borderStyle="border" imageScaling="proportionallyDown" inset="2" id="14" customClass="ConstrainedWindowButtonCell">
<behavior key="behavior" pushIn="YES" lightByBackground="YES" lightByGray="YES"/>
<font key="font" metaFont="system"/>
@@ -86,6 +92,7 @@ Gw
<button verticalHuggingPriority="750" id="11" customClass="ConstrainedWindowButton">
<rect key="frame" x="116" y="12" width="96" height="32"/>
<autoresizingMask key="autoresizingMask" flexibleMinX="YES" flexibleMaxY="YES"/>
+ <animations/>
<buttonCell key="cell" type="push" title="^IDS_LOGIN_DIALOG_OK_BUTTON_LABEL" bezelStyle="rounded" alignment="center" borderStyle="border" imageScaling="proportionallyDown" inset="2" id="12" customClass="ConstrainedWindowButtonCell">
<behavior key="behavior" pushIn="YES" lightByBackground="YES" lightByGray="YES"/>
<font key="font" metaFont="system"/>
@@ -98,14 +105,16 @@ DQ
</connections>
</button>
</subviews>
+ <animations/>
</customView>
<customView id="34" customClass="GTMWidthBasedTweaker">
- <rect key="frame" x="20" y="62" width="89" height="68"/>
+ <rect key="frame" x="20" y="74" width="89" height="68"/>
groby-ooo-7-16 2015/11/24 01:41:56 Deliberately moved?
palmer 2015/12/01 21:15:21 Yes because of the text field, I believe.
<autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/>
<subviews>
<textField verticalHuggingPriority="750" id="5">
<rect key="frame" x="-3" y="8" width="86" height="17"/>
<autoresizingMask key="autoresizingMask" flexibleMinX="YES" flexibleMinY="YES"/>
+ <animations/>
<textFieldCell key="cell" scrollable="YES" lineBreakMode="clipping" sendsActionOnEndEditing="YES" title="^IDS_LOGIN_DIALOG_PASSWORD_FIELD" id="6">
<font key="font" metaFont="cellTitle"/>
<color key="textColor" name="controlTextColor" catalog="System" colorSpace="catalog"/>
@@ -115,6 +124,7 @@ DQ
<textField verticalHuggingPriority="750" id="3">
<rect key="frame" x="-3" y="40" width="86" height="17"/>
<autoresizingMask key="autoresizingMask" flexibleMinX="YES" flexibleMinY="YES"/>
+ <animations/>
<textFieldCell key="cell" scrollable="YES" lineBreakMode="clipping" sendsActionOnEndEditing="YES" title="^IDS_LOGIN_DIALOG_USERNAME_FIELD" id="4">
<font key="font" metaFont="cellTitle"/>
<color key="textColor" name="controlTextColor" catalog="System" colorSpace="catalog"/>
@@ -122,23 +132,36 @@ DQ
</textFieldCell>
</textField>
</subviews>
+ <animations/>
<connections>
<outlet property="viewToResize_" destination="1" id="39"/>
<outlet property="viewToSlideAndResize_" destination="24" id="40"/>
</connections>
</customView>
<textField verticalHuggingPriority="750" id="41">
- <rect key="frame" x="18" y="139" width="365" height="17"/>
+ <rect key="frame" x="18" y="151" width="365" height="17"/>
groby-ooo-7-16 2015/11/24 01:41:55 Deliberately moved?
palmer 2015/12/01 21:15:21 Yes, same reason, I believe.
<autoresizingMask key="autoresizingMask" widthSizable="YES" flexibleMaxY="YES"/>
+ <animations/>
<textFieldCell key="cell" sendsActionOnEndEditing="YES" title="explanation" id="42">
<font key="font" metaFont="cellTitle"/>
<color key="textColor" name="controlTextColor" catalog="System" colorSpace="catalog"/>
<color key="backgroundColor" name="controlColor" catalog="System" colorSpace="catalog"/>
</textFieldCell>
</textField>
+ <textField verticalHuggingPriority="750" id="abu-ex-fsZ">
+ <rect key="frame" x="19" y="176" width="365" height="17"/>
groby-ooo-7-16 2015/11/24 01:41:55 That's rather wide, and you seem to have a texfiel
palmer 2015/12/01 21:15:21 I don't know; that's just what Interface Builder o
+ <autoresizingMask key="autoresizingMask" widthSizable="YES" flexibleMaxY="YES"/>
+ <animations/>
+ <textFieldCell key="cell" sendsActionOnEndEditing="YES" title="authority" id="8wI-KZ-dbK">
groby-ooo-7-16 2015/11/24 01:41:56 Numerical ID, probably.
palmer 2015/12/01 21:15:21 Done.
+ <font key="font" metaFont="cellTitle"/>
+ <color key="textColor" name="controlTextColor" catalog="System" colorSpace="catalog"/>
+ <color key="backgroundColor" name="controlColor" catalog="System" colorSpace="catalog"/>
+ </textFieldCell>
+ </textField>
<textField verticalHuggingPriority="750" id="50">
- <rect key="frame" x="17" y="167" width="353" height="19"/>
+ <rect key="frame" x="17" y="201" width="353" height="19"/>
<autoresizingMask key="autoresizingMask" widthSizable="YES" flexibleMinY="YES"/>
+ <animations/>
<textFieldCell key="cell" sendsActionOnEndEditing="YES" title="^IDS_LOGIN_DIALOG_TITLE" id="51">
<font key="font" metaFont="system" size="15"/>
<color key="textColor" name="controlTextColor" catalog="System" colorSpace="catalog"/>
@@ -146,10 +169,12 @@ DQ
</textFieldCell>
</textField>
</subviews>
+ <animations/>
</view>
<connections>
<outlet property="initialFirstResponder" destination="7" id="56"/>
</connections>
+ <point key="canvasLocation" x="681" y="449"/>
groby-ooo-7-16 2015/11/24 01:41:56 I think you can kill this.
palmer 2015/12/01 21:15:21 Done.
</window>
<customObject id="35" customClass="GTMUILocalizerAndLayoutTweaker">
<connections>
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/android/chrome_http_auth_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698