Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4072)

Unified Diff: chrome/browser/ui/views/login_prompt_views.cc

Issue 1466473003: Do not show untrustworthy strings in the basic auth dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix XIB. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/login/login_prompt.cc ('k') | chrome/browser/ui/views/login_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/login_prompt_views.cc
diff --git a/chrome/browser/ui/views/login_prompt_views.cc b/chrome/browser/ui/views/login_prompt_views.cc
index 3e45f79dbb656214bafd117dccb6ddcb4a110ac1..c1195871bd1ad19c71881416b7e06b7ed6efa8cd 100644
--- a/chrome/browser/ui/views/login_prompt_views.cc
+++ b/chrome/browser/ui/views/login_prompt_views.cc
@@ -100,7 +100,8 @@ class LoginHandlerViews : public LoginHandler, public views::DialogDelegate {
}
// LoginHandler:
- void BuildViewImpl(const base::string16& explanation,
+ void BuildViewImpl(const base::string16& authority,
+ const base::string16& explanation,
LoginModelData* login_model_data) override {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
@@ -109,7 +110,7 @@ class LoginHandlerViews : public LoginHandler, public views::DialogDelegate {
// browser window, so the view may be destroyed after the password
// manager. The view listens for model destruction and unobserves
// accordingly.
- login_view_ = new LoginView(explanation, login_model_data);
+ login_view_ = new LoginView(authority, explanation, login_model_data);
// Scary thread safety note: This can potentially be called *after* SetAuth
// or CancelAuth (say, if the request was cancelled before the UI thread got
« no previous file with comments | « chrome/browser/ui/login/login_prompt.cc ('k') | chrome/browser/ui/views/login_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698