Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3228)

Unified Diff: chrome/browser/ui/android/login_prompt_android.cc

Issue 1466473003: Do not show untrustworthy strings in the basic auth dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix XIB. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/android/chrome_http_auth_handler.cc ('k') | chrome/browser/ui/cocoa/login_prompt_cocoa.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/android/login_prompt_android.cc
diff --git a/chrome/browser/ui/android/login_prompt_android.cc b/chrome/browser/ui/android/login_prompt_android.cc
index 6bb32e2c7fd440cbb2c4d0af93178ca160d9fd3a..53cfd39a5e0823cafdd325d1f42c5f49e47f98d7 100644
--- a/chrome/browser/ui/android/login_prompt_android.cc
+++ b/chrome/browser/ui/android/login_prompt_android.cc
@@ -37,7 +37,8 @@ class LoginHandlerAndroid : public LoginHandler {
}
void OnLoginModelDestroying() override {}
- void BuildViewImpl(const base::string16& explanation,
+ void BuildViewImpl(const base::string16& authority,
+ const base::string16& explanation,
LoginModelData* login_model_data) override {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
@@ -49,7 +50,8 @@ class LoginHandlerAndroid : public LoginHandler {
// Notify WindowAndroid that HTTP authentication is required.
if (window_helper->GetWindowAndroid()) {
- chrome_http_auth_handler_.reset(new ChromeHttpAuthHandler(explanation));
+ chrome_http_auth_handler_.reset(
+ new ChromeHttpAuthHandler(authority, explanation));
chrome_http_auth_handler_->Init();
chrome_http_auth_handler_->SetObserver(this);
chrome_http_auth_handler_->ShowDialog(
« no previous file with comments | « chrome/browser/ui/android/chrome_http_auth_handler.cc ('k') | chrome/browser/ui/cocoa/login_prompt_cocoa.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698