Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5448)

Unified Diff: chrome/browser/ui/views/login_view.h

Issue 1466473003: Do not show untrustworthy strings in the basic auth dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/login_view.h
diff --git a/chrome/browser/ui/views/login_view.h b/chrome/browser/ui/views/login_view.h
index b2cb06fd57ae5d892056e450bc47703ddaff2d64..8afba64a4be5ea7a1a7767bae89304c064a47a1c 100644
--- a/chrome/browser/ui/views/login_view.h
+++ b/chrome/browser/ui/views/login_view.h
@@ -24,7 +24,8 @@ class LoginView : public views::View,
// |login_model_data->model| is observed for the entire lifetime of the
// LoginView. Therefore |login_model_data->model| should not be destroyed
// before the LoginView object. |login_model_data| may be null.
- LoginView(const base::string16& explanation,
+ LoginView(const base::string16& authority,
+ const base::string16& explanation,
LoginHandler::LoginModelData* login_model_data);
~LoginView() override;
@@ -52,7 +53,8 @@ class LoginView : public views::View,
views::Label* username_label_;
views::Label* password_label_;
- // Authentication message.
+ // Authority and realm messages.
meacer 2015/11/20 00:31:30 Authority and explanation messages?
palmer 2015/11/20 01:29:53 Done.
+ views::Label* authority_label_;
views::Label* message_label_;
// If not null, points to a model we need to notify of our own destruction

Powered by Google App Engine
This is Rietveld 408576698